----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34529/#review84808 -----------------------------------------------------------
Hi Mark, Can you fold in the operators that are added in: https://reviews.apache.org/r/34518 please? Thanks! 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp <https://reviews.apache.org/r/34529/#comment136193> 2 new lines (add 1 more). Same below. 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp <https://reviews.apache.org/r/34529/#comment136194> Can we have a more meaningful name for this class? 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp <https://reviews.apache.org/r/34529/#comment136196> Why do we need to introduce a class here? Can we not just have an Option<int> or Option<string>? 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp <https://reviews.apache.org/r/34529/#comment136197> Let's use the full name `Reference` 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp <https://reviews.apache.org/r/34529/#comment136198> let's use full or more meaningful names for these variables. - Joris Van Remoortere On May 21, 2015, 10:36 p.m., Mark Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34529/ > ----------------------------------------------------------- > > (Updated May 21, 2015, 10:36 p.m.) > > > Review request for mesos and Joris Van Remoortere. > > > Bugs: MESOS-2716 > https://issues.apache.org/jira/browse/MESOS-2716 > > > Repository: mesos > > > Description > ------- > > Add non-const reference version of Option<T>::get. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp > ea79b501d9ed7b7da9636ce9c9c590738a586993 > 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp > 7ae3b8ffc5df7f8442e72b1a10d50c3f5c373d8c > > Diff: https://reviews.apache.org/r/34529/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Mark Wang > >
