> On May 27, 2015, 2:18 a.m., Niklas Nielsen wrote: > > Hey Marco, > > > > First pass: One high-level question to your patch: Could we reuse > > JSON::Protobuf() to some of the modeling? > > https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp#L568 > > > > If the IP is wrong type, we can perhaps correct it after parsing it with > > JSON::Protobuf()?
Hey Nik - thanks for super-quick review. Very happy to use JSON::Protobuf - what does it do? Do you know where I can find some documentation or example usage? Thanks for pointing me to it - "random walk" code learning is kinda hit 'n miss :) (but the only option when there's no docs around...) - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34687/#review85311 ----------------------------------------------------------- On May 26, 2015, 11:54 p.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34687/ > ----------------------------------------------------------- > > (Updated May 26, 2015, 11:54 p.m.) > > > Review request for mesos, haosdent huang and Niklas Nielsen. > > > Bugs: MESOS-2340 > https://issues.apache.org/jira/browse/MESOS-2340 > > > Repository: mesos > > > Description > ------- > > Jira: MESOS-2340 > > This is a preliminary step to enabling JSON API > for Master Discovery via Zookeeper. > > We currently save the MasterInfo PB to ZK > serializing directly the binary data, so that > for clients to retrieve that information, they > need to either link up with libmesos or > obtain the PB definition (in mesos/mesos.proto). > > This change only provides the (de)serialization > utility methods and associated tests. > > > Diffs > ----- > > src/Makefile.am 814468e3c5c750a6649b5eeb7c7f945f9e025c19 > src/common/protobuf_utils.hpp 9ecd2343689252af1b997392ec367d14d55ac7d1 > src/common/protobuf_utils.cpp bd6996159e73bf63bb7c2fa3a28def6a2be92b1b > src/tests/common/protobuf_utils_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/34687/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Marco Massenzio > >
