> On May 27, 2015, 2:18 a.m., Niklas Nielsen wrote: > > src/common/protobuf_utils.hpp, line 83 > > <https://reviews.apache.org/r/34687/diff/1/?file=972329#file972329line83> > > > > Shouldn't parse() go in > > https://github.com/apache/mesos/blob/master/src/common/parse.hpp?
I don't really know - in the file there's nothing to say one way or the other: it just seems a bunch of `parse()` methods (in the `flagss::` namespace) converting from `string` to `protobuf`? I guess so, if one takes the stance the similarly named methods should all be in the same header file... I actually prefer to keep methods *logically* grouped and, ideally, the two to/from conversions next to each other, so it's easier to keep them in sync if either formats (JSON / PBuf) ought to change. Also, not particularly fond of methods kept inline and in header files - but that's a matter of taste, I can easily be convinced either way. > On May 27, 2015, 2:18 a.m., Niklas Nielsen wrote: > > src/common/protobuf_utils.hpp, line 87 > > <https://reviews.apache.org/r/34687/diff/1/?file=972329#file972329line87> > > > > We traditionally spell out variable names. Here, minfo would be > > masterInfo or simply 'info' fixed everywhere to `masterInfo` - awfully sorry about that. > On May 27, 2015, 2:18 a.m., Niklas Nielsen wrote: > > src/tests/common/protobuf_utils_tests.cpp, line 23 > > <https://reviews.apache.org/r/34687/diff/1/?file=972331#file972331line23> > > > > This (and standard c includes) goes first > > Marco Massenzio wrote: > haven't we changed this recently? > (I was assuming that the protobuf_utils.hpp was the 'relevant' header?) ok - fixed this (incidentally, I'd copied the order from `http_tests.cpp` which includes `gtest/gtest.h` before `<vector>`) I still assume that `common/protobuf_utils.hpp` can be regarded as the `"related header"` and should be first: correct? - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34687/#review85311 ----------------------------------------------------------- On May 26, 2015, 11:54 p.m., Marco Massenzio wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34687/ > ----------------------------------------------------------- > > (Updated May 26, 2015, 11:54 p.m.) > > > Review request for mesos, haosdent huang and Niklas Nielsen. > > > Bugs: MESOS-2340 > https://issues.apache.org/jira/browse/MESOS-2340 > > > Repository: mesos > > > Description > ------- > > Jira: MESOS-2340 > > This is a preliminary step to enabling JSON API > for Master Discovery via Zookeeper. > > We currently save the MasterInfo PB to ZK > serializing directly the binary data, so that > for clients to retrieve that information, they > need to either link up with libmesos or > obtain the PB definition (in mesos/mesos.proto). > > This change only provides the (de)serialization > utility methods and associated tests. > > > Diffs > ----- > > src/Makefile.am 814468e3c5c750a6649b5eeb7c7f945f9e025c19 > src/common/protobuf_utils.hpp 9ecd2343689252af1b997392ec367d14d55ac7d1 > src/common/protobuf_utils.cpp bd6996159e73bf63bb7c2fa3a28def6a2be92b1b > src/tests/common/protobuf_utils_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/34687/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Marco Massenzio > >
