This is an automatically generated e-mail. To reply, visit:

(Updated May 27, 2015, 6:07 p.m.)

Review request for mesos, haosdent huang and Niklas Nielsen.


Addressed comments
Replaced 'manual' parsing with JSON::Protobuf
Updated tests

Bugs: MESOS-2340

Repository: mesos


Jira: MESOS-2340

This is a preliminary step to enabling JSON API
for Master Discovery via Zookeeper.

We currently save the MasterInfo PB to ZK
serializing directly the binary data, so that
for clients to retrieve that information, they
need to either link up with libmesos or
obtain the PB definition (in mesos/mesos.proto).

This change only provides the (de)serialization
utility methods and associated tests.

Diffs (updated)

  src/Makefile.am 814468e3c5c750a6649b5eeb7c7f945f9e025c19 
  src/common/protobuf_utils.hpp 9ecd2343689252af1b997392ec367d14d55ac7d1 
  src/common/protobuf_utils.cpp bd6996159e73bf63bb7c2fa3a28def6a2be92b1b 
  src/tests/common/protobuf_utils_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/34687/diff/


make check


Marco Massenzio

Reply via email to