----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/#review85757 -----------------------------------------------------------
include/mesos/slave/qos_controller.hpp <https://reviews.apache.org/r/34631/#comment137507> Instead of calling them best-effor or BE tasks, lets just call them revocable tasks? That way it'll be easy to correlate revocable tasks with revocable resources. include/mesos/slave/qos_controller.hpp <https://reviews.apache.org/r/34631/#comment137508> s/BE/revocable/ include/mesos/slave/qos_controller.hpp <https://reviews.apache.org/r/34631/#comment137510> s/QoSCorrection/list<QoSCorrection>/ ? src/slave/qos_controller.hpp <https://reviews.apache.org/r/34631/#comment137509> s/our/out/ - Vinod Kone On May 26, 2015, 3:30 p.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34631/ > ----------------------------------------------------------- > > (Updated May 26, 2015, 3:30 p.m.) > > > Review request for mesos, Bartek Plotka, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added QoS Controller class and NOOP controller implementation > > > Diffs > ----- > > include/mesos/slave/qos_controller.hpp PRE-CREATION > src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 > src/slave/qos_controller.hpp PRE-CREATION > src/slave/qos_controller.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/34631/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
