> On May 29, 2015, 5:39 p.m., Vinod Kone wrote:
> > include/mesos/slave/qos_controller.hpp, line 62
> > <https://reviews.apache.org/r/34631/diff/2/?file=971661#file971661line62>
> >
> >     s/QoSCorrection/list<QoSCorrection>/ ?

Probably calling it 'correction' and returns a single QoSCorrection? Can you 
remind me why we want to return a list?


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34631/#review85757
-----------------------------------------------------------


On May 26, 2015, 3:30 p.m., Niklas Nielsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34631/
> -----------------------------------------------------------
> 
> (Updated May 26, 2015, 3:30 p.m.)
> 
> 
> Review request for mesos, Bartek Plotka, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added QoS Controller class and NOOP controller implementation
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/qos_controller.hpp PRE-CREATION 
>   src/Makefile.am 34755cf795391c9b8051a5e4acc6caf844984496 
>   src/slave/qos_controller.hpp PRE-CREATION 
>   src/slave/qos_controller.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/34631/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Niklas Nielsen
> 
>

Reply via email to