----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34816/#review85806 -----------------------------------------------------------
you need to rebase this on the latest master src/tests/mesos.hpp <https://reviews.apache.org/r/34816/#comment137610> s/Mock/Test/ since this wraps a real estimator. src/tests/mesos.hpp <https://reviews.apache.org/r/34816/#comment137614> 2 blank lines. src/tests/mesos.hpp <https://reviews.apache.org/r/34816/#comment137615> 2 blank lines. src/tests/mesos.hpp <https://reviews.apache.org/r/34816/#comment137616> 2 blank lines. src/tests/mesos.hpp <https://reviews.apache.org/r/34816/#comment137617> Was slave::NoopResourceEstimator not enough? src/tests/oversubscription_tests.cpp <https://reviews.apache.org/r/34816/#comment137619> kill new line. - Vinod Kone On May 29, 2015, 6:18 p.m., Bartek Plotka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34816/ > ----------------------------------------------------------- > > (Updated May 29, 2015, 6:18 p.m.) > > > Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod > Kone. > > > Repository: mesos > > > Description > ------- > > This patch prepares Resource Estimator tests for modularized > ResourceEstimator. > > It includes: > 1. Made oversubscription_test to be typed_test. > 2. TestResourceEstimator changed to be a templated MockResourceEstimator with > mocked methods - to inject resources and test plumbing between RE and Slave. > > > Diffs > ----- > > src/tests/mesos.hpp b8f7a2f9236166e42421d926718af8d45e857eba > src/tests/oversubscription_tests.cpp > 75c25b04c1e6a8e0e7e8fd55440743fe1699af88 > > Diff: https://reviews.apache.org/r/34816/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bartek Plotka > >
