> On June 1, 2015, 1:46 p.m., Niklas Nielsen wrote: > > src/tests/oversubscription_tests.cpp, lines 225-226 > > <https://reviews.apache.org/r/34816/diff/4/?file=975492#file975492line225> > > > > We can merge these two with multiple put() on a queue :) > > Bartek Plotka wrote: > That's true, but in previous issue you asked to delete the queue ;p > https://reviews.apache.org/r/34816/#comment_container_137589 > IMO in these tests there are two or one promise at one time, so it is > more clear - it describes the flow. E.g: We can specify than one is a normal > estimation and second is reduced one. If there were more promises (in more > complicated test case) then obviously the queue would be preferable. However > i am not strongly tied to that approach - we can add queue.
That was not the point - that was about having estimate() on the test class, when the queue could be owned by the test body. I apologize if that didn't came across. - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34816/#review86066 ----------------------------------------------------------- On May 31, 2015, 10:37 p.m., Bartek Plotka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34816/ > ----------------------------------------------------------- > > (Updated May 31, 2015, 10:37 p.m.) > > > Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod > Kone. > > > Repository: mesos > > > Description > ------- > > This patch prepares Resource Estimator tests for modularized > ResourceEstimator. > > It includes: > 1. Made oversubscription_test to be typed_test. > 2. TestResourceEstimator changed to be a templated MockResourceEstimator with > mocked methods - to inject resources and test plumbing between RE and Slave. > > > Diffs > ----- > > src/tests/mesos.hpp ac986a0687a576a0bd5693c82b3c7d543aaa956b > src/tests/oversubscription_tests.cpp > ea5857cb579aa904fd05530684bdde51a0b3f27f > > Diff: https://reviews.apache.org/r/34816/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bartek Plotka > >
