----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/#review86026 -----------------------------------------------------------
docs/mesos-c++-style-guide.md <https://reviews.apache.org/r/34835/#comment137875> Add full-stop punctuation for consistency. docs/mesos-c++-style-guide.md <https://reviews.apache.org/r/34835/#comment137873> s/objections/objects/ ;-) This is worded as how _you_ intend to use constexpr for constexpr static *variables* and one consequence of using them in that manner. Can you be a bit more general as to what it enables? Can you explicitly state our policy on constexpr {variables, functions, constructors}? Document some examples and explicitly state the requirement on literal types and that e.g., std::string is *not*? Are we discussing a switch to 'constexpr char foo[] = "bar"'? - Ian Downes On May 29, 2015, 4:23 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34835/ > ----------------------------------------------------------- > > (Updated May 29, 2015, 4:23 p.m.) > > > Review request for mesos, Benjamin Hindman, Dave Lester, Ian Downes, and > Vinod Kone. > > > Bugs: MESOS-2784 > https://issues.apache.org/jira/browse/MESOS-2784 > > > Repository: mesos > > > Description > ------- > > Add constexpr to C++11 whitelist > > > Diffs > ----- > > docs/mesos-c++-style-guide.md 13312f6f4fe1788791479bd768f60df0a8e80e69 > > Diff: https://reviews.apache.org/r/34835/diff/ > > > Testing > ------- > > > Thanks, > > Paul Brett > >
