----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34835/#review89559 -----------------------------------------------------------
Ship it! docs/mesos-c++-style-guide.md (line 535) <https://reviews.apache.org/r/34835/#comment142184> "uses also converted to `const`" isn't grammatically correct, please revise. docs/mesos-c++-style-guide.md (line 537) <https://reviews.apache.org/r/34835/#comment142185> Isn't this conflating constexpr variables and constexpr functions, i.e., inline is only for constexpr functions? - Ian Downes On June 24, 2015, 2:14 p.m., Paul Brett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34835/ > ----------------------------------------------------------- > > (Updated June 24, 2015, 2:14 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd > Mathiske, Ben Mahler, Dave Lester, Ian Downes, Joerg Schad, Joris Van > Remoortere, Michael Park, Till Toenshoff, and Vinod Kone. > > > Bugs: MESOS-2784 > https://issues.apache.org/jira/browse/MESOS-2784 > > > Repository: mesos > > > Description > ------- > > Add constexpr to C++11 whitelist > > > Diffs > ----- > > docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e > > Diff: https://reviews.apache.org/r/34835/diff/ > > > Testing > ------- > > > Thanks, > > Paul Brett > >
