-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34835/#review88352
-----------------------------------------------------------



docs/mesos-c++-style-guide.md (line 535)
<https://reviews.apache.org/r/34835/#comment140830>

    s/hard coded/hard-coded



docs/mesos-c++-style-guide.md (line 538)
<https://reviews.apache.org/r/34835/#comment140832>

    s/,/. Combining these two sentences deemphasizes the general demand of the 
first one.



docs/mesos-c++-style-guide.md (line 553)
<https://reviews.apache.org/r/34835/#comment140835>

    All "," could be "." here.
    
    "," before "or" missing.



docs/mesos-c++-style-guide.md (line 562)
<https://reviews.apache.org/r/34835/#comment140837>

    Shouldn't ``` be on the next line?



docs/mesos-c++-style-guide.md (line 569)
<https://reviews.apache.org/r/34835/#comment140839>

    const?



docs/mesos-c++-style-guide.md (line 571)
<https://reviews.apache.org/r/34835/#comment140838>

    Intentional extra blank line(s)?


- Bernd Mathiske


On June 17, 2015, 1:05 p.m., Paul Brett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34835/
> -----------------------------------------------------------
> 
> (Updated June 17, 2015, 1:05 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Hindman, Bernd 
> Mathiske, Ben Mahler, Dave Lester, Ian Downes, Joerg Schad, Joris Van 
> Remoortere, Till Toenshoff, and Vinod Kone.
> 
> 
> Bugs: MESOS-2784
>     https://issues.apache.org/jira/browse/MESOS-2784
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add constexpr to C++11 whitelist
> 
> 
> Diffs
> -----
> 
>   docs/mesos-c++-style-guide.md 94107ed21c6f09349ce691f9f4d36b43bbbe809e 
> 
> Diff: https://reviews.apache.org/r/34835/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Paul Brett
> 
>

Reply via email to