> On May 28, 2015, 11:53 p.m., Marco Massenzio wrote: > > Folks - this thing has been out for almost four months now, we should > > really get it moving. > > > > @alexdr - can you please address Nik's comments (Nik - you got late to the > > party :) but that's ok) > > > > @till - I think Alex addressed your comments, can you please give it a > > quick once-over and, unless you see major trouble, can we please commit? > > > > In general, high-level API/protocol isssues should be hashed out during the > > design state (here's to hoping we had a Design Doc for this API back in the > > day: this patch pre-dates me by more than two months!) so that when we come > > to the implementation stage, there are no longer discussions about URI > > structure, payload, etc. > > > > Thanks everyone for helping moving this forward! > > Adam B wrote: > I would love to see a document detailing (with examples) what > does/doesn't go into each nested endpoint. The FRAMEWORKS_HELP is rather > vague. > And I am concerned about the payloads of these different endpoints. > /state.json is already very bloated, and I'm not convinced a /frameworks that > includes all info on all tasks is going to be any better.
@adam-mesos: So we were talking jesterday with ben about the rationale behind this patch (after all I just continued made an old patch work). After all we came to the following conclusions: 1. It is true that this can be bloated, though no as bloated as `state.json` since `/frameworks` is a subset of the former. 2. The reason behind this (and `/slaves`) endpoint is to unravel `/state.json` into multiple more specific endpoints. 3. I will write now a document providing a broad roadmap for this unraveling. With more specifics into the `/frameworks` and `/slaves` endpoints. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review85628 ----------------------------------------------------------- On May 29, 2015, 4:47 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30612/ > ----------------------------------------------------------- > > (Updated May 29, 2015, 4:47 p.m.) > > > Review request for mesos, Adam B, Joerg Schad, Marco Massenzio, Niklas > Nielsen, and Till Toenshoff. > > > Bugs: MESOS-2157 > https://issues.apache.org/jira/browse/MESOS-2157 > > > Repository: mesos > > > Description > ------- > > Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}. > > Adds tests for the endpoints. > > Works with [29883](https://reviews.apache.org/r/29883). > > Builds on the abandoned patch 14286. > > > Diffs > ----- > > src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0 > src/master/master.hpp c0cc2933a2cc094401f633df12356bda3d294564 > src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d > src/tests/master_tests.cpp ba3858fb3026f2cc7af0523bd1a0c541eeafc34b > > Diff: https://reviews.apache.org/r/30612/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
