> On May 21, 2015, 7:37 p.m., Niklas Nielsen wrote: > > src/tests/master_tests.cpp, lines 1829-1836 > > <https://reviews.apache.org/r/30612/diff/17/?file=963579#file963579line1829> > > > > I don't think we should not have tests and asserts in SetUp(). Are all > > theses tasks and setup used in each test?
I don't understand your double negation, but I think you mean the "not" in "…should not have…" doesn't come here. In that case, what is your suggestion? assume start up successds without a problem? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review84734 ----------------------------------------------------------- On May 19, 2015, 10:42 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30612/ > ----------------------------------------------------------- > > (Updated May 19, 2015, 10:42 a.m.) > > > Review request for mesos, Adam B, Joerg Schad, Marco Massenzio, Niklas > Nielsen, and Till Toenshoff. > > > Bugs: MESOS-2157 > https://issues.apache.org/jira/browse/MESOS-2157 > > > Repository: mesos > > > Description > ------- > > Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}. > > Adds tests for the endpoints. > > Works with [29883](https://reviews.apache.org/r/29883). > > Builds on the abandoned patch 14286. > > > Diffs > ----- > > src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0 > src/master/master.hpp da0a83510784f4f7dbd933e666ac12c04c413a62 > src/master/master.cpp eaea79df2c693d15087d70b3c9b988e57c894f8e > src/tests/master_tests.cpp ba3858fb3026f2cc7af0523bd1a0c541eeafc34b > > Diff: https://reviews.apache.org/r/30612/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
