> On May 18, 2015, 1:18 p.m., Till Toenshoff wrote:
> > src/master/http.cpp, line 312
> > <https://reviews.apache.org/r/30612/diff/15/?file=947349#file947349line312>
> >
> >     `const`?
> 
> Alexander Rojas wrote:
>     Cannot be const because the operator `[]` provides no const overload 
> (common problem on the std library)

You may consider using `.at()` or `.get()` instead. They both have `const` 
accessors.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30612/#review82935
-----------------------------------------------------------


On May 19, 2015, 8:42 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30612/
> -----------------------------------------------------------
> 
> (Updated May 19, 2015, 8:42 a.m.)
> 
> 
> Review request for mesos, Adam B, Joerg Schad, Marco Massenzio, Niklas 
> Nielsen, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2157
>     https://issues.apache.org/jira/browse/MESOS-2157
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds endpoints for paths /master/frameworks/{framework}/tasks/{task}.
> 
> Adds tests for the endpoints.
> 
> Works with [29883](https://reviews.apache.org/r/29883).
> 
> Builds on the abandoned patch 14286.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 01dbdad9720a9cd30505683ae1117970cda918a0 
>   src/master/master.hpp da0a83510784f4f7dbd933e666ac12c04c413a62 
>   src/master/master.cpp eaea79df2c693d15087d70b3c9b988e57c894f8e 
>   src/tests/master_tests.cpp ba3858fb3026f2cc7af0523bd1a0c541eeafc34b 
> 
> Diff: https://reviews.apache.org/r/30612/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to