> On May 29, 2015, 7:23 p.m., Vinod Kone wrote: > > src/tests/oversubscription_tests.cpp, line 117 > > <https://reviews.apache.org/r/34633/diff/1/?file=970999#file970999line117> > > > > Why not implement the TODO? > > > > s/AWAIT_READY(received)/AWAIT_ASSERT_EQ(expected, received)/ ? > > Niklas Nielsen wrote: > We still don't have the equality operator overload - want me to throw > that in a dependent review?
i see. nm then. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34633/#review85775 ----------------------------------------------------------- On June 3, 2015, 4:29 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34633/ > ----------------------------------------------------------- > > (Updated June 3, 2015, 4:29 a.m.) > > > Review request for mesos, Bartek Plotka, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added new QoS Controller test which use the TestQoSController to fill the > correction queue and verify the slave receiving corrections. > > > Diffs > ----- > > src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e > src/tests/oversubscription_tests.cpp > f047b90d8f0b4dfe7e6cad6dc58909451e9f894b > > Diff: https://reviews.apache.org/r/34633/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
