> On June 3, 2015, 4:33 p.m., Jie Yu wrote: > > src/tests/oversubscription_tests.cpp, lines 339-340 > > <https://reviews.apache.org/r/34633/diff/2/?file=977220#file977220line339> > > > > Can you use initalization list here? > > > > ``` > > list<QoSCorrection> expected = { QosCorrection() }; > > corrections.put(expected); > > ```
Thanks! Great suggestion :) > On June 3, 2015, 4:33 p.m., Jie Yu wrote: > > src/tests/oversubscription_tests.cpp, line 352 > > <https://reviews.apache.org/r/34633/diff/2/?file=977220#file977220line352> > > > > I don't think you need this. Ah - thanks! - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34633/#review86508 ----------------------------------------------------------- On June 4, 2015, 10:42 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34633/ > ----------------------------------------------------------- > > (Updated June 4, 2015, 10:42 a.m.) > > > Review request for mesos, Bartek Plotka, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added new QoS Controller test which use the TestQoSController to fill the > correction queue and verify the slave receiving corrections. > > > Diffs > ----- > > src/tests/oversubscription_tests.cpp > 43a13eec4aab564f84eadb99970b041faa0379f8 > > Diff: https://reviews.apache.org/r/34633/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
