----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34633/#review86508 -----------------------------------------------------------
Ship it! src/tests/oversubscription_tests.cpp <https://reviews.apache.org/r/34633/#comment138567> Can you move this line right after ``` TestContainerizer containerizer; ``` src/tests/oversubscription_tests.cpp <https://reviews.apache.org/r/34633/#comment138563> Can you add 'using testing::Invoke' and get rid of the prefix here? src/tests/oversubscription_tests.cpp <https://reviews.apache.org/r/34633/#comment138564> Please add a using clause above to avoid the namespace prefix:) src/tests/oversubscription_tests.cpp <https://reviews.apache.org/r/34633/#comment138566> Can you use initalization list here? ``` list<QoSCorrection> expected = { QosCorrection() }; corrections.put(expected); ``` src/tests/oversubscription_tests.cpp <https://reviews.apache.org/r/34633/#comment138568> I don't think you need this. - Jie Yu On June 3, 2015, 4:29 a.m., Niklas Nielsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34633/ > ----------------------------------------------------------- > > (Updated June 3, 2015, 4:29 a.m.) > > > Review request for mesos, Bartek Plotka, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added new QoS Controller test which use the TestQoSController to fill the > correction queue and verify the slave receiving corrections. > > > Diffs > ----- > > src/tests/mesos.hpp aeeed61ea987963345a8b5c6e09d14e51098bb2e > src/tests/oversubscription_tests.cpp > f047b90d8f0b4dfe7e6cad6dc58909451e9f894b > > Diff: https://reviews.apache.org/r/34633/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Niklas Nielsen > >
