-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35028/#review86502
-----------------------------------------------------------


LGTM :)


src/Makefile.am
<https://reviews.apache.org/r/35028/#comment138551>

    Want to update this comment?



src/slave/resource_estimator.cpp
<https://reviews.apache.org/r/35028/#comment138552>

    How about wrapping like:
    
    ```
        return Error(
            "Could not create resource estimator module '" + type.get() + "': " 
+
            module.error());
    
    ```
    
    or
    
    ```
        return Error(
            "Could not create resource estimator module '" + type.get() +
            "': " + module.error());
    
    ```
    
    There should be enough space :)



src/slave/resource_estimators/fixed.cpp
<https://reviews.apache.org/r/35028/#comment138553>

    Can you const this?



src/slave/resource_estimators/fixed.cpp
<https://reviews.apache.org/r/35028/#comment138557>

    We could consider to capitalize this as it is a name :) i.e. 'Fixed 
Resource Estimator Module'



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/35028/#comment138550>

    We have const char* in for example 
https://github.com/apache/mesos/blob/master/src/tests/hook_tests.cpp#L78
    Want to do that instead?



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/35028/#comment138558>

    This is a bit dense - mind breaking it up a bit and comment?



src/tests/oversubscription_tests.cpp
<https://reviews.apache.org/r/35028/#comment138549>

    Mind adding a test description?


- Niklas Nielsen


On June 3, 2015, 3:05 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35028/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 3:05 p.m.)
> 
> 
> Review request for mesos, Bartek Plotka, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-2791
>     https://issues.apache.org/jira/browse/MESOS-2791
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a fixed resource estimator. The actual implementation is a stub for now.
> 
> I made it a module so that we can leverage the Parameters to set it up 
> (instead of passing in a slave flag).
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 66030c4b211ea61e97e62c35ec1821e0958f9787 
>   src/slave/resource_estimator.cpp 5aaf3052ff1f745408b9fabced3b76ed5424acfa 
>   src/slave/resource_estimators/fixed.cpp PRE-CREATION 
>   src/tests/oversubscription_tests.cpp 
> f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 
> 
> Diff: https://reviews.apache.org/r/35028/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to