----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35028/#review86722 -----------------------------------------------------------
Ship it! src/slave/resource_estimator.cpp <https://reviews.apache.org/r/35028/#comment138779> s/Could not/Failed to/ src/tests/oversubscription_tests.cpp <https://reviews.apache.org/r/35028/#comment138780> s/Ld/LD/ also why conversion to C string? - Vinod Kone On June 4, 2015, 5:56 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35028/ > ----------------------------------------------------------- > > (Updated June 4, 2015, 5:56 p.m.) > > > Review request for mesos, Bartek Plotka, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2791 > https://issues.apache.org/jira/browse/MESOS-2791 > > > Repository: mesos > > > Description > ------- > > Added a fixed resource estimator. The actual implementation is a stub for now. > > I made it a module so that we can leverage the Parameters to set it up > (instead of passing in a slave flag). > > > Diffs > ----- > > src/Makefile.am cc3d2e60fe2bb2b78ca93dd05dbf004a049c4aa5 > src/slave/resource_estimator.cpp 5aaf3052ff1f745408b9fabced3b76ed5424acfa > src/slave/resource_estimators/fixed.cpp PRE-CREATION > src/tests/oversubscription_tests.cpp > 43a13eec4aab564f84eadb99970b041faa0379f8 > > Diff: https://reviews.apache.org/r/35028/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
