> On June 3, 2015, 11:16 p.m., Niklas Nielsen wrote:
> > src/tests/oversubscription_tests.cpp, line 66
> > <https://reviews.apache.org/r/35028/diff/1/?file=977722#file977722line66>
> >
> >     We have const char* in for example 
> > https://github.com/apache/mesos/blob/master/src/tests/hook_tests.cpp#L78
> >     Want to do that instead?
> 
> Jie Yu wrote:
>     I thought we decided to use char[] consistently? That's what we've been 
> doing in isolators.
>     
>     Should we make a decision and change that in the style guide?
>     
>     cc Ben Mahler, Vinod Kone

```
[tw-172-25-131-112 mesos (fixed_resource_estimator)]$ grep -R -e "const 
char.*[]" src/                                                                  
                                                        
src//jvm/org/apache/log4j.cpp:const char LEVEL_OFF_SIGNATURE[] = 
"Lorg/apache/log4j/Level;";
src//jvm/org/apache/log4j.cpp:const char LEVEL_OFF[] = "OFF";
src//jvm/org/apache/log4j.hpp:extern const char LEVEL_OFF_SIGNATURE[];
src//jvm/org/apache/log4j.hpp:extern const char LEVEL_OFF[];
src//jvm/org/apache/zookeeper.cpp:const char 
ZOOKEEPERSERVER_SESSIONTRACKER_SIGNATURE[] =
src//jvm/org/apache/zookeeper.cpp:const char ZOOKEEPERSERVER_SESSIONTRACKER[] = 
"sessionTracker";
src//jvm/org/apache/zookeeper.hpp:extern const char 
ZOOKEEPERSERVER_SESSIONTRACKER_SIGNATURE[];
src//jvm/org/apache/zookeeper.hpp:extern const char 
ZOOKEEPERSERVER_SESSIONTRACKER[];
src//linux/perf.cpp:static const char PERF_DELIMITER[] = ",";
src//linux/perf.cpp:static const char PIDS_KEY[] = "";
src//slave/containerizer/isolators/namespaces/pid.cpp:static const char 
PID_NS_BIND_MOUNT_ROOT[] = "/var/run/mesos/pidns";
src//slave/containerizer/isolators/namespaces/pid.cpp:static const char 
PID_NS_BIND_MOUNT_MASK_DIR[] = "/var/empty/mesos";
src//slave/containerizer/isolators/network/port_mapping.cpp:const char 
NET_TCP_ACTIVE_CONNECTIONS[] = "net_tcp_active_connections";
src//slave/containerizer/isolators/network/port_mapping.cpp:const char 
NET_TCP_TIME_WAIT_CONNECTIONS[] = "net_tcp_time_wait_connections";
src//slave/containerizer/isolators/network/port_mapping.cpp:const char 
NET_TCP_RTT_MICROSECS_P50[] = "net_tcp_rtt_microsecs_p50";
src//slave/containerizer/isolators/network/port_mapping.cpp:const char 
NET_TCP_RTT_MICROSECS_P90[] = "net_tcp_rtt_microsecs_p90";
src//slave/containerizer/isolators/network/port_mapping.cpp:const char 
NET_TCP_RTT_MICROSECS_P95[] = "net_tcp_rtt_microsecs_p95";
src//slave/containerizer/isolators/network/port_mapping.cpp:const char 
NET_TCP_RTT_MICROSECS_P99[] = "net_tcp_rtt_microsecs_p99";
src//slave/containerizer/isolators/network/port_mapping.hpp:extern const char 
NET_TCP_ACTIVE_CONNECTIONS[];
src//slave/containerizer/isolators/network/port_mapping.hpp:extern const char 
NET_TCP_TIME_WAIT_CONNECTIONS[];
src//slave/containerizer/isolators/network/port_mapping.hpp:extern const char 
NET_TCP_RTT_MICROSECS_P50[];
src//slave/containerizer/isolators/network/port_mapping.hpp:extern const char 
NET_TCP_RTT_MICROSECS_P90[];
src//slave/containerizer/isolators/network/port_mapping.hpp:extern const char 
NET_TCP_RTT_MICROSECS_P95[];
src//slave/containerizer/isolators/network/port_mapping.hpp:extern const char 
NET_TCP_RTT_MICROSECS_P99[];
src//slave/containerizer/mesos/containerizer.cpp:const char 
MESOS_CONTAINERIZER[] = "mesos-containerizer";
src//slave/containerizer/mesos/containerizer.hpp:extern const char 
MESOS_CONTAINERIZER[];
src//slave/paths.cpp:const char BOOT_ID_FILE[] = "boot_id";
src//slave/paths.cpp:const char SLAVE_INFO_FILE[] = "slave.info";
src//slave/paths.cpp:const char FRAMEWORK_PID_FILE[] = "framework.pid";
src//slave/paths.cpp:const char FRAMEWORK_INFO_FILE[] = "framework.info";
src//slave/paths.cpp:const char LIBPROCESS_PID_FILE[] = "libprocess.pid";
src//slave/paths.cpp:const char EXECUTOR_INFO_FILE[] = "executor.info";
src//slave/paths.cpp:const char EXECUTOR_SENTINEL_FILE[] = "executor.sentinel";
src//slave/paths.cpp:const char FORKED_PID_FILE[] = "forked.pid";
src//slave/paths.cpp:const char TASK_INFO_FILE[] = "task.info";
src//slave/paths.cpp:const char TASK_UPDATES_FILE[] = "task.updates";
src//slave/paths.cpp:const char RESOURCES_INFO_FILE[] = "resources.info";
src//slave/paths.hpp:const char LATEST_SYMLINK[] = "latest";
src//tests/memory_test_helper.cpp:const char INCREASE_RSS[] = "INCREASE_RSS";
src//tests/memory_test_helper.cpp:const char INCREASE_PAGE_CACHE[] = 
"INCREASE_PAGE_CACHE";
src//tests/memory_test_helper.cpp:const char MemoryTestHelperMain::NAME[] = 
"MemoryTestHelperMain";
src//tests/memory_test_helper.hpp:  static const char NAME[];
src//tests/oversubscription_tests.cpp:const char 
FIXED_RESOURCE_ESTIMATOR_NAME[] =
src//tests/setns_test_helper.cpp:const char SetnsTestHelper::NAME[] = 
"SetnsTestHelper";
src//tests/setns_test_helper.hpp:  static const char NAME[];
```


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35028/#review86502
-----------------------------------------------------------


On June 3, 2015, 10:05 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35028/
> -----------------------------------------------------------
> 
> (Updated June 3, 2015, 10:05 p.m.)
> 
> 
> Review request for mesos, Bartek Plotka, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-2791
>     https://issues.apache.org/jira/browse/MESOS-2791
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a fixed resource estimator. The actual implementation is a stub for now.
> 
> I made it a module so that we can leverage the Parameters to set it up 
> (instead of passing in a slave flag).
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 66030c4b211ea61e97e62c35ec1821e0958f9787 
>   src/slave/resource_estimator.cpp 5aaf3052ff1f745408b9fabced3b76ed5424acfa 
>   src/slave/resource_estimators/fixed.cpp PRE-CREATION 
>   src/tests/oversubscription_tests.cpp 
> f047b90d8f0b4dfe7e6cad6dc58909451e9f894b 
> 
> Diff: https://reviews.apache.org/r/35028/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to