> On June 8, 2015, 5:34 p.m., Jie Yu wrote:
> > I think the interface of getting resource usage is going to change per 
> > discussion here:
> > https://issues.apache.org/jira/browse/MESOS-2818
> 
> Niklas Nielsen wrote:
>     The new proposal doesn't mention changing the callback, does it?
> 
> Jie Yu wrote:
>     The new protobuf message is what needed by the resource estimator:
>     ```
>     message ResourceUsage {
>       message Executor {
>         optional ExecutorInfo executor_info = 1;
>         repeated Resource allocated = 2;
>         repeated ResourceStatistics statistics = 3;
>       }
>     
>       repeated Resource total = 1; // Slave's total resources.
>       repeated Executor executors = 2; // Per-executor allocated/usage 
> information.
>     }
>     ```
>     
>     So we'll need to change the interface accordingly.

To rephrase, it is because we no longer have a list of ResourceUsages? Can you 
advise how to change accordingly?
Please make these kind of blocking comments actionable. We have traditionally 
spent way to much time getting blocked in the 11th hour (either having to redo 
completely or drop). We have to redo this for the resource estimator anyway; so 
that can be done in a single pass (moving from the previous pattern to the new 
one).

Any recommendations?


- Niklas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35164/#review87106
-----------------------------------------------------------


On June 5, 2015, 4:44 p.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35164/
> -----------------------------------------------------------
> 
> (Updated June 5, 2015, 4:44 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2823
>     https://issues.apache.org/jira/browse/MESOS-2823
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Passed callback to the QoS Controller to retrieve ResourceUsage from Resource 
> Monitor on demand.
> 
> This is neccessary, since QoS Controller needs data (current statistics for 
> each executor) on which it will base its potential corrections.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/qos_controller.hpp 
> 1d89acfd9c742b044674e0a0815f9f01eccb69b3 
>   src/slave/qos_controller.hpp b37798303561eb79aee202b9c110794517eeed06 
>   src/slave/qos_controller.cpp 81c4b3e658902be0438f42d9e86911e424828a73 
>   src/slave/slave.cpp 054929b156374a8929ac9fffb032045f13c3eb43 
>   src/tests/mesos.hpp 087953d6bc716f11c315a0736f06f712d7f69417 
> 
> Diff: https://reviews.apache.org/r/35164/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Reply via email to