> On June 9, 2015, 12:34 a.m., Jie Yu wrote: > > I think the interface of getting resource usage is going to change per > > discussion here: > > https://issues.apache.org/jira/browse/MESOS-2818 > > Niklas Nielsen wrote: > The new proposal doesn't mention changing the callback, does it? > > Jie Yu wrote: > The new protobuf message is what needed by the resource estimator: > ``` > message ResourceUsage { > message Executor { > optional ExecutorInfo executor_info = 1; > repeated Resource allocated = 2; > repeated ResourceStatistics statistics = 3; > } > > repeated Resource total = 1; // Slave's total resources. > repeated Executor executors = 2; // Per-executor allocated/usage > information. > } > ``` > > So we'll need to change the interface accordingly. > > Niklas Nielsen wrote: > To rephrase, it is because we no longer have a list of ResourceUsages? > Can you advise how to change accordingly? > Please make these kind of blocking comments actionable. We have > traditionally spent way to much time getting blocked in the 11th hour (either > having to redo completely or drop). We have to redo this for the resource > estimator anyway; so that can be done in a single pass (moving from the > previous pattern to the new one). > > Any recommendations? > > Jie Yu wrote: > > To rephrase, it is because we no longer have a list of ResourceUsages? > > Yes. > > I'll probably wait until the new interfaces are out and rebase since this > is a relatively small patch. I'll get the changes out today. > > Although, I am ok if you want to commit this one (i'll need to rebase > mine). > > Bartek Plotka wrote: > Niklas +1 > > > The only change will be s/list// for this patch and resource Estimator is > todo anyway. Can we ship it and change when MESOS-2818 patch is ready?
Rebased JieYu patches, so this patch should be now ready to be shiped! (: - Bartek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35164/#review87106 ----------------------------------------------------------- On June 12, 2015, 12:20 a.m., Bartek Plotka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35164/ > ----------------------------------------------------------- > > (Updated June 12, 2015, 12:20 a.m.) > > > Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod > Kone. > > > Bugs: MESOS-2823 > https://issues.apache.org/jira/browse/MESOS-2823 > > > Repository: mesos > > > Description > ------- > > Passed callback to the QoS Controller to retrieve ResourceUsage from Resource > Monitor on demand. > > This is neccessary, since QoS Controller needs data (current statistics for > each executor) on which it will base its potential corrections. > > > Diffs > ----- > > include/mesos/slave/qos_controller.hpp > 1d89acfd9c742b044674e0a0815f9f01eccb69b3 > src/slave/qos_controller.hpp b37798303561eb79aee202b9c110794517eeed06 > src/slave/qos_controller.cpp febb2365f51ca226df699badb8626cbdfc1430b9 > src/slave/slave.cpp b523c2fce50e56f4f94d55a9488f49c53452e4d4 > src/tests/mesos.hpp e19ef984f9e4696bd405027d6f19756cf23d0df2 > > Diff: https://reviews.apache.org/r/35164/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Bartek Plotka > >
