-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35164/#review87724
-----------------------------------------------------------

Ship it!



include/mesos/slave/qos_controller.hpp
<https://reviews.apache.org/r/35164/#comment140133>

    Kill the space in front of 'QoS'



include/mesos/slave/qos_controller.hpp
<https://reviews.apache.org/r/35164/#comment140134>

    s/usages/usage/



src/slave/qos_controller.hpp
<https://reviews.apache.org/r/35164/#comment140135>

    s/usages/usage/



src/slave/qos_controller.cpp
<https://reviews.apache.org/r/35164/#comment140136>

    No need to use `process::` prefix
    
    And s/usages/usage/


- Jie Yu


On June 12, 2015, 12:20 a.m., Bartek Plotka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35164/
> -----------------------------------------------------------
> 
> (Updated June 12, 2015, 12:20 a.m.)
> 
> 
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod 
> Kone.
> 
> 
> Bugs: MESOS-2823
>     https://issues.apache.org/jira/browse/MESOS-2823
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Passed callback to the QoS Controller to retrieve ResourceUsage from Resource 
> Monitor on demand.
> 
> This is neccessary, since QoS Controller needs data (current statistics for 
> each executor) on which it will base its potential corrections.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/qos_controller.hpp 
> 1d89acfd9c742b044674e0a0815f9f01eccb69b3 
>   src/slave/qos_controller.hpp b37798303561eb79aee202b9c110794517eeed06 
>   src/slave/qos_controller.cpp febb2365f51ca226df699badb8626cbdfc1430b9 
>   src/slave/slave.cpp b523c2fce50e56f4f94d55a9488f49c53452e4d4 
>   src/tests/mesos.hpp e19ef984f9e4696bd405027d6f19756cf23d0df2 
> 
> Diff: https://reviews.apache.org/r/35164/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Bartek Plotka
> 
>

Reply via email to