> On June 10, 2015, 9:52 p.m., Ben Mahler wrote: > > src/slave/resource_estimators/fixed.cpp, line 60 > > <https://reviews.apache.org/r/35260/diff/2/?file=982137#file982137line60> > > > > Whoops! Remove the reference?
This is fixed in https://reviews.apache.org/r/35320/ > On June 10, 2015, 9:52 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 4197 > > <https://reviews.apache.org/r/35260/diff/2/?file=982141#file982141line4197> > > > > Seems ok for now, but a bit odd that we're copying it in the capture, > > since ideally we want to move. Yeah, I'll add a NOTE here. > On June 10, 2015, 9:52 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, lines 4213-4215 > > <https://reviews.apache.org/r/35260/diff/2/?file=982141#file982141line4213> > > > > Want a CHECK_EQ on the sizes? Added. > On June 10, 2015, 9:52 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, lines 4224-4226 > > <https://reviews.apache.org/r/35260/diff/2/?file=982141#file982141line4224> > > > > I know we're inconsistent about this, but we should probably single > > quote the ID here, since it's coming from the framework. Done. > On June 10, 2015, 9:52 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, line 4462 > > <https://reviews.apache.org/r/35260/diff/2/?file=982141#file982141line4462> > > > > Trivial, but wrapping after "Fix" looks less jagged? Done. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35260/#review87459 ----------------------------------------------------------- On June 10, 2015, 6:29 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35260/ > ----------------------------------------------------------- > > (Updated June 10, 2015, 6:29 p.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2818 > https://issues.apache.org/jira/browse/MESOS-2818 > > > Repository: mesos > > > Description > ------- > > Refactored the ResourceMonitor to get statistics from the Slave. > > 1) Modified ResourceUsage to include allocation information (see ticket for > reaons). > 2) Simplied the ResourceMonitor by taking a lambda from the slave to get > statistics. > 3) Adjusted (and simplified) the MonitorTest accordingly. > > > Diffs > ----- > > include/mesos/mesos.proto 7457ff11f6a55099ccb95beb2f0ccb9a2f7ccd87 > include/mesos/slave/resource_estimator.hpp > 7f78fd86760397d5b885a2c00b41081d0b546cdd > src/slave/monitor.hpp bee91ba143c26059fc8badf56beccb68c6556cb7 > src/slave/monitor.cpp 8f7ff63b4daf0286d4cf912e2f3d2d1b68caab1c > src/slave/resource_estimators/fixed.cpp > 3efa18d7e3c6ac62e67f75ea45a832f3f6349036 > src/slave/resource_estimators/noop.hpp > 7a44e6deefc9c1985c14d076a427aa5c654aa1bb > src/slave/resource_estimators/noop.cpp > 5f135ff37e84c248ede29bbe4a7d1b8319417e20 > src/slave/slave.hpp 4d2c31688b19f101ec851c0d94e7d45aa2f8a76e > src/slave/slave.cpp 98036b2d5f2c765aef4a416c3cbc082df77ab3ac > src/tests/mesos.hpp 087953d6bc716f11c315a0736f06f712d7f69417 > src/tests/monitor_tests.cpp 6de8b1f65843fd7b852dfa69627a1c435b482fe0 > > Diff: https://reviews.apache.org/r/35260/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >