-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35260/#review87592
-----------------------------------------------------------

Ship it!



include/mesos/mesos.proto
<https://reviews.apache.org/r/35260/#comment139991>

    Does this represent the total resources allocated for the container 
(executor + tasks) or only tasks? If the first; then let's update this comment



src/slave/monitor.cpp
<https://reviews.apache.org/r/35260/#comment139993>

    C-style headers should be before C++ - take a look at zookeeper.cpp



src/slave/slave.cpp
<https://reviews.apache.org/r/35260/#comment139994>

    I am not sure about lambda wrappings, but shouldn't it as least be 4 indent 
taken a argument wrapping?
    
    Can we prevent that wrapping by wrapping a bit earlier?



src/tests/monitor_tests.cpp
<https://reviews.apache.org/r/35260/#comment139995>

    What do you need to copy in this lambda scope? I just saw a comment from 
BenH about preferring being explicit on bringing the environment in.
    
    The style guide suggests that you can do either; I will let that be up to 
you.


- Niklas Nielsen


On June 10, 2015, 4:13 p.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35260/
> -----------------------------------------------------------
> 
> (Updated June 10, 2015, 4:13 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-2818
>     https://issues.apache.org/jira/browse/MESOS-2818
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored the ResourceMonitor to get statistics from the Slave.
> 
> 1) Modified ResourceUsage to include allocation information (see ticket for 
> reaons).
> 2) Simplied the ResourceMonitor by taking a lambda from the slave to get 
> statistics.
> 3) Adjusted (and simplified) the MonitorTest accordingly.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 7457ff11f6a55099ccb95beb2f0ccb9a2f7ccd87 
>   include/mesos/slave/resource_estimator.hpp 
> 7f78fd86760397d5b885a2c00b41081d0b546cdd 
>   src/slave/monitor.hpp bee91ba143c26059fc8badf56beccb68c6556cb7 
>   src/slave/monitor.cpp 8f7ff63b4daf0286d4cf912e2f3d2d1b68caab1c 
>   src/slave/resource_estimators/fixed.cpp 
> 3efa18d7e3c6ac62e67f75ea45a832f3f6349036 
>   src/slave/resource_estimators/noop.hpp 
> 7a44e6deefc9c1985c14d076a427aa5c654aa1bb 
>   src/slave/resource_estimators/noop.cpp 
> 5f135ff37e84c248ede29bbe4a7d1b8319417e20 
>   src/slave/slave.hpp 98c64f62f60c286e42379b2151321b190c4410b8 
>   src/slave/slave.cpp b9fb929684ae582b9133126fefa5a06d4181d836 
>   src/tests/mesos.hpp 087953d6bc716f11c315a0736f06f712d7f69417 
>   src/tests/monitor_tests.cpp 6de8b1f65843fd7b852dfa69627a1c435b482fe0 
> 
> Diff: https://reviews.apache.org/r/35260/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>

Reply via email to