> On June 11, 2015, 4:18 p.m., Niklas Nielsen wrote: > > include/mesos/mesos.proto, line 626 > > <https://reviews.apache.org/r/35260/diff/3/?file=982288#file982288line626> > > > > I just thought of one thing - this represents the entire container and > > not the executor alone. Does it make sense to call it 'Container' instead?
+1 - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35260/#review87571 ----------------------------------------------------------- On June 10, 2015, 11:13 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35260/ > ----------------------------------------------------------- > > (Updated June 10, 2015, 11:13 p.m.) > > > Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone. > > > Bugs: MESOS-2818 > https://issues.apache.org/jira/browse/MESOS-2818 > > > Repository: mesos > > > Description > ------- > > Refactored the ResourceMonitor to get statistics from the Slave. > > 1) Modified ResourceUsage to include allocation information (see ticket for > reaons). > 2) Simplied the ResourceMonitor by taking a lambda from the slave to get > statistics. > 3) Adjusted (and simplified) the MonitorTest accordingly. > > > Diffs > ----- > > include/mesos/mesos.proto 7457ff11f6a55099ccb95beb2f0ccb9a2f7ccd87 > include/mesos/slave/resource_estimator.hpp > 7f78fd86760397d5b885a2c00b41081d0b546cdd > src/slave/monitor.hpp bee91ba143c26059fc8badf56beccb68c6556cb7 > src/slave/monitor.cpp 8f7ff63b4daf0286d4cf912e2f3d2d1b68caab1c > src/slave/resource_estimators/fixed.cpp > 3efa18d7e3c6ac62e67f75ea45a832f3f6349036 > src/slave/resource_estimators/noop.hpp > 7a44e6deefc9c1985c14d076a427aa5c654aa1bb > src/slave/resource_estimators/noop.cpp > 5f135ff37e84c248ede29bbe4a7d1b8319417e20 > src/slave/slave.hpp 98c64f62f60c286e42379b2151321b190c4410b8 > src/slave/slave.cpp b9fb929684ae582b9133126fefa5a06d4181d836 > src/tests/mesos.hpp 087953d6bc716f11c315a0736f06f712d7f69417 > src/tests/monitor_tests.cpp 6de8b1f65843fd7b852dfa69627a1c435b482fe0 > > Diff: https://reviews.apache.org/r/35260/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
