-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35367/#review87624
-----------------------------------------------------------


Patch looks great!

Reviews applied: [35367]

All tests passed.

- Mesos ReviewBot


On June 11, 2015, 7:56 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35367/
> -----------------------------------------------------------
> 
> (Updated June 11, 2015, 7:56 p.m.)
> 
> 
> Review request for mesos, Niklas Nielsen and Vinod Kone.
> 
> 
> Bugs: MESOS-2838
>     https://issues.apache.org/jira/browse/MESOS-2838
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> "Combine" means taking the sum of scalars or coalescing ranges and sets of 
> all resources of the same name regardless of their other attributes.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 7da6e6e8bc1fa1d62fc8be2b5169b68e10392b73 
>   src/common/http.cpp 2ac7fba7a3aac913540f1b09768777393b79284a 
>   src/common/resources.cpp 05969199889c6bc1421c8e5be10c74a50660719f 
>   src/tests/common/http_tests.cpp f087b2313a13c3199b70b3d7feb728e1449a52e7 
> 
> Diff: https://reviews.apache.org/r/35367/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> Added a test `HTTP.ModelResources` for this.
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Reply via email to