reviews
Thread
Date
Later messages
Messages by Date
2020/02/24
Re: Review Request 71886: Set container's `cpu.cfs_quota_us` to its CPU resource limit.
Qian Zhang
2020/02/24
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
2020/02/24
Re: Review Request 72065: Improved performance of v1 agent operator API GET_EXECUTORS call.
Benjamin Mahler
2020/02/24
Re: Review Request 71858: Set resource limits when launching executor container.
Qian Zhang
2020/02/24
Review Request 72162: Accommodated the "Infinity" value in the JSON <-> Protobuf conversion.
Qian Zhang
2020/02/24
Review Request 72161: Added patch for RapidJSON.
Qian Zhang
2020/02/24
Re: Review Request 72056: Improved performance of v1 agent operator API GET_METRICS call.
Andrei Sekretenko
2020/02/24
Re: Review Request 72064: Improved performance of v1 agent operator API GET_FRAMEWORKS call.
Andrei Sekretenko
2020/02/24
Re: Review Request 72067: Improved performance of v1 agent operator API GET_STATE call.
Andrei Sekretenko
2020/02/24
Re: Review Request 72066: Improved performance of v1 agent operator API GET_TASKS call.
Andrei Sekretenko
2020/02/24
Re: Review Request 72065: Improved performance of v1 agent operator API GET_EXECUTORS call.
Andrei Sekretenko
2020/02/24
Re: Review Request 72064: Improved performance of v1 agent operator API GET_FRAMEWORKS call.
Andrei Sekretenko
2020/02/24
Re: Review Request 72158: Fixed systemd socket activation on old systemd versions.
Andrei Sekretenko
2020/02/24
Re: Review Request 72158: Fixed systemd socket activation on old systemd versions.
Mesos Reviewbot
2020/02/24
Re: Review Request 72158: Fixed systemd socket activation on old systemd versions.
Andrei Budnik
2020/02/24
Re: Review Request 72158: Fixed systemd socket activation on old systemd versions.
Andrei Budnik
2020/02/24
Re: Review Request 72158: Fixed systemd socket activation on old systemd versions.
Andrei Budnik
2020/02/24
Re: Review Request 72157: Removed reimplementation of `cloexec` from systemd activation code.
Andrei Budnik
2020/02/24
Re: Review Request 72157: Removed reimplementation of `cloexec` from systemd activation code.
Andrei Budnik
2020/02/24
Re: Review Request 72158: Fixed systemd socket activation on old systemd versions.
Andrei Sekretenko
2020/02/24
Re: Review Request 72157: Removed reimplementation of `cloexec` from systemd activation code.
Andrei Sekretenko
2020/02/22
[GitHub] [mesos] dharmeshkakadia opened a new pull request #350: Fix book thumbnail link
GitBox
2020/02/21
Re: Review Request 72158: Fixed systemd socket activation on old systemd versions.
Mesos Reviewbot
2020/02/21
Re: Review Request 72158: Fixed systemd socket activation on old systemd versions.
Mesos Reviewbot
2020/02/21
Review Request 72157: Removed reimplementation of `cloexec` code in systemd activation code.
Andrei Budnik
2020/02/21
Review Request 72158: Fixed systemd socket activation on old systemd versions.
Andrei Budnik
2020/02/20
Re: Review Request 72099: Removed code for tracking pending tasks.
Benjamin Mahler
2020/02/20
Re: Review Request 72098: Converted ACCEPT to synchronous authorization.
Benjamin Mahler
2020/02/20
Re: Review Request 72097: Converted UPDATE_FRAMEWORK to synchronous authorization.
Benjamin Mahler
2020/02/20
Re: Review Request 72095: Introduced dedicated `Framework` methods for transitions between states.
Benjamin Mahler
2020/02/20
Re: Review Request 72096: Store per-framework ObjectApprovers.
Benjamin Mahler
2020/02/20
Re: Review Request 72093: Added to `ObjectApprovers` a method to approve arbitrary action.
Benjamin Mahler
2020/02/20
Re: Review Request 72089: Introduced `provideObjectApprover(...)` authorizer interface.
Benjamin Mahler
2020/02/18
Re: Review Request 72099: Removed code for tracking pending tasks.
Mesos Reviewbot
2020/02/14
Re: Review Request 72122: Fixed `cgroups::create` for nested cgroups.
Mesos Reviewbot
2020/02/14
Re: Review Request 72099: Removed code for tracking pending tasks.
Mesos Reviewbot
2020/02/13
Re: Review Request 72130: Added heartbeater deletion when HTTP framework is disconnected.
Benjamin Mahler
2020/02/13
Re: Review Request 72099: Removed code for tracking pending tasks.
Mesos Reviewbot
2020/02/13
Re: Review Request 72122: Fixed `cgroups::create` for nested cgroups.
Mesos Reviewbot
2020/02/13
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
2020/02/13
Re: Review Request 72098: Converted ACCEPT to synchronous authorization.
Andrei Sekretenko
2020/02/13
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
2020/02/13
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
2020/02/13
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
2020/02/13
Re: Review Request 72099: Removed code for tracking pending tasks.
Mesos Reviewbot
2020/02/13
Re: Review Request 72094: Made `http`, `pid` and `heartbeater` of `Framework` private.
Andrei Sekretenko
2020/02/13
Review Request 72130: Added heartbeater deletion when HTTP framework is disconnected.
Andrei Sekretenko
2020/02/12
Re: Review Request 72126: Added a test to ensure agents cannot be reactivated while DRAINING.
Mesos Reviewbot
2020/02/12
Re: Review Request 72124: Added logging of tasks and operations during agent drain initiation.
Mesos Reviewbot
2020/02/12
Review Request 72126: Added a test to ensure agents cannot be reactivated while DRAINING.
Benjamin Mahler
2020/02/12
Review Request 72125: Disallow reactivating a DRAINING agent.
Benjamin Mahler
2020/02/12
Review Request 72124: Added logging of tasks and operations during agent drain initiation.
Benjamin Mahler
2020/02/12
Re: Review Request 72099: Removed code for tracking pending tasks.
Mesos Reviewbot
2020/02/12
Re: Review Request 72094: Made `http`, `pid` and `heartbeater` of `Framework` private.
Benjamin Mahler
2020/02/12
Re: Review Request 72122: Fixed `cgroups::create` for nested cgroups.
Mesos Reviewbot
2020/02/12
Re: Review Request 72099: Removed code for tracking pending tasks.
Andrei Sekretenko
2020/02/12
Re: Review Request 72096: Store per-framework ObjectApprovers.
Andrei Sekretenko
2020/02/12
Re: Review Request 72095: Introduced dedicated `Framework` methods for transitions between states.
Andrei Sekretenko
2020/02/12
Re: Review Request 72094: Made `http`, `pid` and `heartbeater` of `Framework` private.
Andrei Sekretenko
2020/02/12
Re: Review Request 72094: Made `http`, `pid` and `heartbeater` of `Framework` private.
Andrei Sekretenko
2020/02/12
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Andrei Budnik
2020/02/12
Re: Review Request 72122: Fixed `cgroups::create` for nested cgroups.
Mesos Reviewbot
2020/02/12
Review Request 72122: Fixed `cgroups::create` for nested cgroups.
Andrei Budnik
2020/02/12
Review Request 72121: Moved cgroup path helpers to `paths.hpp`.
Andrei Budnik
2020/02/12
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Andrei Budnik
2020/02/12
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
2020/02/12
Re: Review Request 72099: Removed code for tracking pending tasks.
Andrei Sekretenko
2020/02/11
Re: Review Request 72116: Fixed incorrect task count logging in master's agent draining logic.
Mesos Reviewbot
2020/02/11
Re: Review Request 72116: Fixed incorrect task count logging in master's agent draining logic.
Joseph Wu
2020/02/11
Review Request 72116: Fixed incorrect task count logging in master's agent draining logic.
Benjamin Mahler
2020/02/11
Re: Review Request 72114: Removed remaining domain socket code from the Windows build.
Mesos Reviewbot
2020/02/11
Re: Review Request 72114: Removed remaining domain socket code from the Windows build.
Benjamin Bannier
2020/02/11
Re: Review Request 72114: Removed remaining domain socket code from the Windows build.
Greg Mann
2020/02/11
Review Request 72114: Removed remaining domain socket code from the Windows build.
Greg Mann
2020/02/11
Re: Review Request 72107: Fixed Windows command argument stringification.
Mesos Reviewbot
2020/02/11
Re: Review Request 72107: Fixed Windows command argument stringification.
Benjamin Bannier
2020/02/11
Review Request 72107: Fixed Windows command argument stringification.
Greg Mann
2020/02/09
Re: Review Request 72090: Introduced a weak_ptr-based cache abstraction.
Benjamin Mahler
2020/02/07
Re: Review Request 72093: Added to `ObjectApprovers` a method to approve arbitrary action.
Benjamin Mahler
2020/02/07
Re: Review Request 72094: Made `http`, `pid` and `heartbeater` of Framework private.
Benjamin Mahler
2020/02/07
Re: Review Request 72095: Tied tracking framework state and connection state together.
Benjamin Mahler
2020/02/07
Re: Review Request 72099: Removed code for tracking pending tasks.
Benjamin Mahler
2020/02/07
Re: Review Request 72099: Removed code for tracking pending tasks.
Benjamin Mahler
2020/02/07
Re: Review Request 72099: Removed code for tracking pending tasks.
Mesos Reviewbot
2020/02/07
Review Request 72097: Converted UPDATE_FRAMEWORK to synchronous authorization.
Andrei Sekretenko
2020/02/07
Review Request 72091: Got rid of LocalAuthorizerProcess::authorize(...) method.
Andrei Sekretenko
2020/02/07
Review Request 72095: Tied tracking framework state and connection state together.
Andrei Sekretenko
2020/02/07
Review Request 72098: Converted ACCEPT to synchronous authorization.
Andrei Sekretenko
2020/02/07
Review Request 72099: Removed code for tracking pending tasks.
Andrei Sekretenko
2020/02/07
Review Request 72096: Store per-framework ObjectApprovers.
Andrei Sekretenko
2020/02/07
Review Request 72093: Added to `ObjectApprovers` a method to approve arbitrary action.
Andrei Sekretenko
2020/02/07
Review Request 72094: Made `http`, `pid` and `heartbeater` of Framework private.
Andrei Sekretenko
2020/02/07
Review Request 72092: Added `ObjectApprover`s caching to the local authorizer.
Andrei Sekretenko
2020/02/07
Review Request 72090: Introduced a weak_ptr-based cache abstraction.
Andrei Sekretenko
2020/02/07
Review Request 72089: Introduced `provideObjectApprover(...)` authorizer interface.
Andrei Sekretenko
2020/02/05
Re: Review Request 72087: Cleaned up agent capability validation and associated docs.
Qian Zhang
2020/02/05
Re: Review Request 72087: Cleaned up agent capability validation and associated docs.
Mesos Reviewbot
2020/02/05
Re: Review Request 71991: Added the 'TASK_RESOURCE_LIMITS' agent capability.
Greg Mann
2020/02/05
Review Request 72087: Cleaned up agent capability validation and associated docs.
Greg Mann
2020/02/05
Re: Review Request 71991: Added the 'TASK_RESOURCE_LIMITS' agent capability.
Greg Mann
2020/02/05
Re: Review Request 72080: Added test for fetch from repositories not providing scope/service.
Mesos Reviewbot
2020/02/05
Re: Review Request 72080: Added test for fetch from repositories not providing scope/service.
Andrei Sekretenko
2020/02/05
Re: Review Request 72080: Added test for fetch from repositories not providing scope/service.
Andrei Sekretenko
2020/02/05
Re: Review Request 72078: Factored out getting authorization service URI.
Andrei Sekretenko
2020/02/04
Re: Review Request 72080: Added test for fetch from repositories not providing scope/service.
Qian Zhang
2020/02/04
Re: Review Request 72079: Added workaround for Docker repositories not providing scope/service.
Qian Zhang
2020/02/04
Re: Review Request 72078: Factored out getting authorization service URI.
Qian Zhang
2020/02/04
Re: Review Request 72077: Factored out common code for building URIs on a registry host.
Qian Zhang
2020/02/04
Re: Review Request 72077: Factored out common code for building URIs on a registry host.
Qian Zhang
2020/02/04
Re: Review Request 71991: Added the 'TASK_RESOURCE_LIMITS' agent capability.
Qian Zhang
2020/02/04
Re: Review Request 71991: Added the 'TASK_RESOURCE_LIMITS' agent capability.
Mesos Reviewbot
2020/02/04
Re: Review Request 71991: Added the 'TASK_RESOURCE_LIMITS' agent capability.
Greg Mann
2020/02/04
Re: Review Request 71991: Added the 'TASK_RESOURCE_LIMITS' agent capability.
Greg Mann
2020/02/04
Re: Review Request 72080: Added test for fetch from repositories not providing scope/service.
Mesos Reviewbot
2020/02/04
Re: Review Request 72079: Added workaround for Docker repositories not providing scope/service.
Andrei Sekretenko
2020/02/04
Re: Review Request 72080: Added test for fetch from repositories not providing scope/service.
Mesos Reviewbot
2020/02/04
Re: Review Request 72078: Factored out getting authorization service URI.
Andrei Sekretenko
2020/02/04
Re: Review Request 72077: Factored out common code for building URIs on a registry host.
Andrei Sekretenko
2020/02/04
Re: Review Request 72079: Added workaround for Docker repositories not providing scope/service.
Andrei Sekretenko
2020/02/04
Re: Review Request 72080: Added test for fetch from repositories not providing scope/service.
Andrei Sekretenko
2020/02/04
Re: Review Request 72077: Factored out common code for building URIs on a repository host.
Andrei Sekretenko
2020/02/04
Re: Review Request 72080: Added test for fetch from repositories not providing scope/service.
Qian Zhang
2020/02/04
Re: Review Request 72079: Added workaround for Docker repositories not providing scope/service.
Qian Zhang
2020/02/03
Re: Review Request 72077: Factored out common code for building URIs on a repository host.
Qian Zhang
2020/02/03
Re: Review Request 72078: Factored out getting authorization server URI.
Qian Zhang
2020/02/03
Re: Review Request 72077: Factored out common code for building URIs on a repository host.
Qian Zhang
2020/02/03
Re: Review Request 72080: Added test for fetch from repositories not providing scope/service.
Mesos Reviewbot
2020/02/03
Review Request 72079: Added workaround for Docker repositories not providing scope/service.
Andrei Sekretenko
2020/02/03
Review Request 72078: Factored out getting authorization server URI.
Andrei Sekretenko
2020/02/03
Review Request 72080: Added test for fetch from repositories not providing scope/service.
Andrei Sekretenko
2020/02/03
Review Request 72077: Factored out common code for building URIs on a repository host.
Andrei Sekretenko
2020/02/03
Re: Review Request 72029: Changed termination logic of the default executor.
Qian Zhang
2020/02/03
Re: Review Request 72055: Changed termination logic of the Docker executor.
Qian Zhang
2020/02/03
Re: Review Request 72055: Changed termination logic of the Docker executor.
Andrei Budnik
2020/02/03
Re: Review Request 72029: Changed termination logic of the default executor.
Andrei Budnik
2020/02/02
Re: Review Request 72070: Fixed the build on Windows.
Greg Mann
2020/02/02
Re: Review Request 71991: Added the 'TASK_RESOURCE_LIMITS' agent capability.
Qian Zhang
2020/02/01
Re: Review Request 72029: Changed termination logic of the default executor.
Qian Zhang
2020/02/01
Re: Review Request 72029: Changed termination logic of the default executor.
Mesos Reviewbot
2020/02/01
Re: Review Request 72029: Changed termination logic of the default executor.
Andrei Budnik
2020/01/31
Re: Review Request 72055: Changed termination logic of the Docker executor.
Qian Zhang
2020/01/31
Re: Review Request 72055: Changed termination logic of the Docker executor.
Qian Zhang
2020/01/31
Re: Review Request 72029: Changed termination logic of the default executor.
Qian Zhang
2020/01/31
Re: Review Request 72070: Fixed the build on Windows.
Mesos Reviewbot
2020/01/31
Review Request 72070: Fixed the build on Windows.
Benjamin Bannier
2020/01/30
Re: Review Request 72029: Changed termination logic of the default executor.
Greg Mann
2020/01/30
Re: Review Request 72029: Changed termination logic of the default executor.
Greg Mann
2020/01/30
Re: Review Request 72068: Removed dead code from v1 API serialization changes.
Mesos Reviewbot
2020/01/30
Review Request 72068: Removed dead code from v1 API serialization changes.
Benjamin Mahler
2020/01/30
Re: Review Request 72064: Improved performance of v1 agent operator API GET_FRAMEWORKS call.
Benjamin Mahler
2020/01/30
Review Request 72064: Improved performance of v1 agent operator API GET_FRAMEWORKS call.
Benjamin Mahler
2020/01/30
Re: Review Request 72056: Improved performance of v1 agent operator API GET_METRICS call.
Benjamin Mahler
2020/01/30
Review Request 72065: Improved performance of v1 agent operator API GET_EXECUTORS call.
Benjamin Mahler
2020/01/30
Review Request 72067: Improved performance of v1 agent operator API GET_STATE call.
Benjamin Mahler
2020/01/30
Review Request 72066: Improved performance of v1 agent operator API GET_TASKS call.
Benjamin Mahler
2020/01/30
Re: Review Request 72029: Changed termination logic of the default executor.
Mesos Reviewbot
2020/01/30
Re: Review Request 72029: Changed termination logic of the default executor.
Andrei Budnik
2020/01/30
Re: Review Request 72029: Changed termination logic of the default executor.
Andrei Budnik
2020/01/30
Re: Review Request 72055: Changed termination logic of the Docker executor.
Andrei Budnik
2020/01/30
Re: Review Request 72055: Changed termination logic of the Docker executor.
Andrei Budnik
2020/01/30
Re: Review Request 72055: Changed termination logic of the Docker executor.
Andrei Budnik
2020/01/29
Re: Review Request 72029: Changed termination logic of the default executor.
Qian Zhang
2020/01/29
Re: Review Request 72055: Changed termination logic of the Docker executor.
Qian Zhang
2020/01/29
Re: Review Request 72055: Changed termination logic of the Docker executor.
Qian Zhang
2020/01/29
Re: Review Request 72055: Changed termination logic of the Docker executor.
Greg Mann
2020/01/29
Re: Review Request 72029: Changed termination logic of the default executor.
Greg Mann
2020/01/29
Re: Review Request 72029: Changed termination logic of the default executor.
Mesos Reviewbot
2020/01/29
Re: Review Request 72029: Changed termination logic of the default executor.
Andrei Budnik
2020/01/29
Re: Review Request 72055: Changed termination logic of the Docker executor.
Mesos Reviewbot
2020/01/29
Re: Review Request 72055: Changed termination logic of the Docker executor.
Andrei Budnik
2020/01/29
Re: Review Request 72055: Changed termination logic of the Docker executor.
Andrei Budnik
2020/01/29
Re: Review Request 72055: Changed logic of termination of the Docker executor.
Vinod Kone
2020/01/29
Re: Review Request 72055: Changed logic of termination of the Docker executor.
Qian Zhang
2020/01/28
Re: Review Request 72056: Improved performance of v1 agent operator API GetMetrics call.
Mesos Reviewbot
2020/01/28
Re: Review Request 72029: Changed logic of termination of the default executor.
Mesos Reviewbot
2020/01/28
Re: Review Request 72017: SSL Socket: Added downgrade support.
Mesos Reviewbot
2020/01/28
Review Request 72056: Improved performance of v1 agent operator API GetMetrics call.
Benjamin Mahler
2020/01/28
Re: Review Request 72055: Changed logic of termination of the Docker executor.
Mesos Reviewbot
2020/01/28
Re: Review Request 72019: Updated master::Call::SUBSCRIBE to be served in parallel.
Benjamin Mahler
2020/01/28
Re: Review Request 72019: Updated master::Call::SUBSCRIBE to be served in parallel.
Andrei Sekretenko
2020/01/28
Review Request 72055: Changed logic of termination of the Docker executor.
Andrei Budnik
2020/01/28
Re: Review Request 72054: Switched `verify-reviews.py` to use ubuntu-16.04-based image.
Andrei Budnik
2020/01/28
Review Request 72054: Switched `verify-reviews.py` to use ubuntu-16.04-based image.
Benjamin Bannier
2020/01/28
Re: Review Request 67631: [WIP] Added non-const accessor for JSON values.
Benjamin Bannier
2020/01/27
Re: Review Request 72018: Windows: Excluded some unix socket code.
Greg Mann
2020/01/27
Re: Review Request 72019: Updated master::Call::SUBSCRIBE to be served in parallel.
Benjamin Mahler
2020/01/27
Re: Review Request 72019: Updated master::Call::SUBSCRIBE to be served in parallel.
Andrei Sekretenko
2020/01/27
Re: Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.
Mesos Reviewbot
2020/01/27
Re: Review Request 71782: Moved check on subscriber presences into subscribers.send.
Mesos Reviewbot
2020/01/27
Re: Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.
Andrei Budnik
2020/01/27
Re: Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.
Benjamin Bannier
2020/01/27
Re: Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.
Andrei Budnik
2020/01/27
Re: Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.
Andrei Budnik
2020/01/23
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
2020/01/23
Review Request 72040: Updated the `LaunchContainer` agent API to support resource limits.
Qian Zhang
2020/01/23
Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Qian Zhang
2020/01/22
Re: Review Request 72035: Remembered whether an executor was agent-generated.
Andrei Sekretenko
2020/01/22
Re: Review Request 72034: Sync'd whether an executor was generated to and from disk.
Andrei Sekretenko
2020/01/22
Re: Review Request 72033: Decoupled detection of generated executors from Mesos install location.
Andrei Sekretenko
2020/01/22
Re: Review Request 72035: Remembered whether an executor was agent-generated.
Mesos Reviewbot
Later messages