reviews
Thread
Date
Later messages
Messages by Date
2020/01/27
Re: Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.
Andrei Budnik
2020/01/27
Re: Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.
Benjamin Bannier
2020/01/27
Re: Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.
Andrei Budnik
2020/01/27
Re: Review Request 71421: Switched verify-reviews from docker-build to prepared Docker image.
Andrei Budnik
2020/01/23
Re: Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Mesos Reviewbot
2020/01/23
Review Request 72040: Updated the `LaunchContainer` agent API to support resource limits.
Qian Zhang
2020/01/23
Review Request 72041: Updated default executor to call the `LaunchContainer` agent API.
Qian Zhang
2020/01/22
Re: Review Request 72035: Remembered whether an executor was agent-generated.
Andrei Sekretenko
2020/01/22
Re: Review Request 72034: Sync'd whether an executor was generated to and from disk.
Andrei Sekretenko
2020/01/22
Re: Review Request 72033: Decoupled detection of generated executors from Mesos install location.
Andrei Sekretenko
2020/01/22
Re: Review Request 72035: Remembered whether an executor was agent-generated.
Mesos Reviewbot
2020/01/22
Re: Review Request 72035: Remembered whether an executor was agent-generated.
Benjamin Bannier
2020/01/22
Re: Review Request 72035: Remembered whether an executor was agent-generated.
Benjamin Bannier
2020/01/22
Re: Review Request 72034: Sync'd whether an executor was generated to and from disk.
Benjamin Bannier
2020/01/22
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
2020/01/21
Re: Review Request 72016: Reverted SSL Socket guard against downgrade.
Greg Mann
2020/01/21
Re: Review Request 72014: SSL Socket: Moved accept callback logic into protected function.
Greg Mann
2020/01/21
Re: Review Request 72019: Updated master::Call::SUBSCRIBE to be served in parallel.
Mesos Reviewbot
2020/01/21
Re: Review Request 72019: Updated master::Call::SUBSCRIBE to be served in parallel.
Benjamin Mahler
2020/01/21
Re: Review Request 72035: Remembered whether an executor was agent-generated.
Mesos Reviewbot
2020/01/21
Re: Review Request 72033: Decoupled detection of generated executors from Mesos install location.
Benjamin Bannier
2020/01/21
Re: Review Request 72035: Remembered whether an executor was agent-generated.
Mesos Reviewbot
2020/01/21
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
2020/01/21
Re: Review Request 72035: Remembered whether an executor was agent-generated.
Andrei Sekretenko
2020/01/21
Re: Review Request 72033: Decoupled detection of generated executors from Mesos install location.
Andrei Sekretenko
2020/01/21
Review Request 72035: Remembered whether an executor was agent-generated.
Benjamin Bannier
2020/01/21
Review Request 72033: Decoupled detection of generated executors from Mesos install location.
Benjamin Bannier
2020/01/21
Review Request 72034: Sync'd whether an executor was generated to and from disk.
Benjamin Bannier
2020/01/21
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
2020/01/20
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
2020/01/20
Re: Review Request 72029: Changed logic of termination of the default executor.
Mesos Reviewbot
2020/01/20
Review Request 72029: Changed logic of termination of the default executor.
Andrei Budnik
2020/01/20
Re: Review Request 72027: Added a new test `ROOT_DOCKER_CGROUPS_CFS_CgroupsEnableCFS`.
Mesos Reviewbot
2020/01/20
Review Request 72027: Added a new test `ROOT_DOCKER_CGROUPS_CFS_CgroupsEnableCFS`.
Qian Zhang
2020/01/19
Re: Review Request 72022: WIP: Set resource limits and OOM score adjustment in Docker executor.
Mesos Reviewbot
2020/01/19
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Mesos Reviewbot
2020/01/19
Re: Review Request 71952: WIP: Set resource limits when updating executor container.
Qian Zhang
2020/01/19
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Qian Zhang
2020/01/18
Re: Review Request 72022: WIP: Set resource limits and OOM score adjustment in Docker executor.
Mesos Reviewbot
2020/01/18
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Mesos Reviewbot
2020/01/18
Re: Review Request 71952: WIP: Set resource limits when updating executor container.
Qian Zhang
2020/01/18
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Qian Zhang
2020/01/17
Re: Review Request 72019: Updated master::Call::SUBSCRIBE to be served in parallel.
Andrei Sekretenko
2020/01/17
Re: Review Request 72011: Removed unintentional copies of for loop iteration variables.
Andrei Sekretenko
2020/01/17
Re: Review Request 72022: WIP: Set resource limits and OOM score adjustment in Docker executor.
Mesos Reviewbot
2020/01/16
Review Request 72022: WIP: Set resource limits and OOM score adjustment in Docker executor.
Qian Zhang
2020/01/16
Re: Review Request 72019: Updated master::Call::SUBSCRIBE to be served in parallel.
Mesos Reviewbot
2020/01/16
Re: Review Request 72019: Updated master::Call::SUBSCRIBE to be served in parallel.
Benjamin Mahler
2020/01/16
Review Request 72019: Updated master::Call::SUBSCRIBE to be served in parallel.
Benjamin Mahler
2020/01/16
Re: Review Request 72018: Windows: Excluded some unix socket code.
Mesos Reviewbot
2020/01/16
Review Request 72014: SSL Socket: Moved accept callback logic into protected function.
Joseph Wu
2020/01/16
Review Request 72016: Reverted SSL Socket guard against downgrade.
Joseph Wu
2020/01/16
Review Request 72018: Windows: Excluded some unix socket code.
Joseph Wu
2020/01/16
Review Request 72017: SSL Socket: Added downgrade support.
Joseph Wu
2020/01/16
Re: Review Request 72011: Removed unintentional copies of for loop iteration variables.
Mesos Reviewbot
2020/01/16
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
2020/01/16
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Andrei Budnik
2020/01/16
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
2020/01/16
Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.
Mesos Reviewbot
2020/01/16
Review Request 72011: Removed unintentional copies of for loop iteration variables.
Benjamin Bannier
2020/01/16
Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.
Andrei Sekretenko
2020/01/16
Re: Review Request 72002: Added `ExecutorInfo` field to tag agent-generated executors.
Andrei Sekretenko
2020/01/16
Re: Review Request 72002: Added `ExecutorInfo` field to tag agent-generated executors.
Benjamin Bannier
2020/01/16
Re: Review Request 72002: Added `ExecutorInfo` field to tag agent-generated executors.
Andrei Sekretenko
2020/01/16
Re: Review Request 72002: Added `ExecutorInfo` field to tag agent-generated executors.
Andrei Sekretenko
2020/01/16
Re: Review Request 72002: Added `ExecutorInfo` field to tag agent-generated executors.
Andrei Sekretenko
2020/01/16
Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.
Benjamin Bannier
2020/01/16
Re: Review Request 72002: Added `ExecutorInfo` field to tag agent-generated executors.
Benjamin Bannier
2020/01/15
Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.
Benjamin Bannier
2020/01/15
Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.
Mesos Reviewbot
2020/01/15
Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
Mesos Reviewbot
2020/01/15
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Mesos Reviewbot
2020/01/15
Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.
Benjamin Bannier
2020/01/15
Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.
Benjamin Bannier
2020/01/15
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
2020/01/15
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.
Qian Zhang
2020/01/15
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
2020/01/15
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
2020/01/15
Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.
Mesos Reviewbot
2020/01/15
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Qian Zhang
2020/01/15
Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.
Andrei Sekretenko
2020/01/15
Review Request 72002: Added `ExecutorInfo` field to tag agent-generated executors.
Benjamin Bannier
2020/01/15
Review Request 72003: Used persisted information to decide if an executor is agent-generated.
Benjamin Bannier
2020/01/14
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Greg Mann
2020/01/14
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Greg Mann
2020/01/14
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Qian Zhang
2020/01/14
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Greg Mann
2020/01/14
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Greg Mann
2020/01/14
Re: Review Request 71978: Updated all GET_* v1 master calls to be served in parallel.
Benjamin Mahler
2020/01/14
Re: Review Request 71996: Fixed issues flagged by cpplint.
Andrei Sekretenko
2020/01/14
Review Request 71996: Fixed issues flagged by cpplint.
Benjamin Bannier
2020/01/14
Re: Review Request 71991: Added the 'TASK_RESOURCE_LIMITS' agent capability.
Mesos Reviewbot
2020/01/14
Re: Review Request 71978: Updated all GET_* v1 master calls to be served in parallel.
Andrei Sekretenko
2020/01/13
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Qian Zhang
2020/01/13
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Qian Zhang
2020/01/13
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Qian Zhang
2020/01/13
Review Request 71991: Added the 'TASK_RESOURCE_LIMITS' agent capability.
Greg Mann
2020/01/13
Re: Review Request 71944: Set container process's OOM score adjust.
Greg Mann
2020/01/13
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Greg Mann
2020/01/13
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Greg Mann
2020/01/13
Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
Mesos Reviewbot
2020/01/13
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Mesos Reviewbot
2020/01/13
[GitHub] [mesos] bbannier merged pull request #349: site: update the year to 2020 in the footer
GitBox
2020/01/13
Re: Review Request 71987: Disabled `DefaultExecutorTest.DomainSockets` on non-Linux platforms.
Benno Evers
2020/01/13
Review Request 71987: Disabled `DefaultExecutorTest.DomainSockets` on non-Linux platforms.
Benjamin Bannier
2020/01/13
Re: Review Request 71986: Removed redundant calls to `c_str` flagged by mesos-tidy.
Till Toenshoff via Review Board
2020/01/13
Re: Review Request 71985: Properly initialized dummy variable.
Till Toenshoff via Review Board
2020/01/13
Review Request 71986: Removed redundant calls to `c_str` flagged by mesos-tidy.
Benjamin Bannier
2020/01/13
Review Request 71985: Properly initialized dummy variable.
Benjamin Bannier
2020/01/13
Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
Qian Zhang
2020/01/13
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
2020/01/12
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Qian Zhang
2020/01/12
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
2020/01/12
Re: Review Request 71977: Added systemd support to domain socket agent flag.
Mesos Reviewbot
2020/01/12
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Qian Zhang
2020/01/12
Re: Review Request 71854: Handled `/api/v1` and /api/v1/executor` over agent executor socket.
Benno Evers
2020/01/11
[GitHub] [mesos] milipili opened a new pull request #349: site: update the year to 2020 in the footer
GitBox
2020/01/11
Re: Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
Mesos Reviewbot
2020/01/11
Review Request 71983: Added a test `CgroupsIsolatorTest.ROOT_CGROUPS_CFS_TaskGroupLimits`.
Qian Zhang
2020/01/11
Re: Review Request 71977: Added systemd support to domain socket agent flag.
Benjamin Bannier
2020/01/11
Re: Review Request 71816: Added domain socket-related flags to Mesos agent.
Benjamin Bannier
2020/01/11
Re: Review Request 71976: Added support for systemd socket activation API.
Benjamin Bannier
2020/01/10
Re: Review Request 71935: Added a new task status reason.
Qian Zhang
2020/01/10
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Greg Mann
2020/01/10
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Greg Mann
2020/01/10
Re: Review Request 71952: WIP: Set resource limits when updating executor container.
Greg Mann
2020/01/10
Re: Review Request 71867: WIP: Support for docker containerizer.
Mesos Reviewbot
2020/01/10
Re: Review Request 71833: Created unix domain socket on agent startup.
Benjamin Bannier
2020/01/10
Re: Review Request 71816: Added domain socket-related flags to Mesos agent.
Benjamin Bannier
2020/01/10
Re: Review Request 71816: Added domain socket-related flags to Mesos agent.
Benjamin Bannier
2020/01/10
Re: Review Request 71977: Added systemd support to domain socket agent flag.
Mesos Reviewbot
2020/01/10
Re: Review Request 71815: Made the default executors connect via domain sockets if available.
Benjamin Bannier
2020/01/10
Re: Review Request 71814: Added support for new 'http+unix' URL scheme in libprocess.
Benjamin Bannier
2020/01/10
[GitHub] [mesos] asfgit closed pull request #348: Add wargaming.net url to Powered By Mesos Page
GitBox
2020/01/10
Re: Review Request 71947: Handled embedded null bytes in abstract domain socket names.
Benjamin Bannier
2020/01/10
Re: Review Request 71947: Handled embedded null bytes in abstract domain socket names.
Benjamin Bannier
2020/01/09
[GitHub] [mesos] brat002 opened a new pull request #348: Add wargaming.net url to Powered By Mesos Page
GitBox
2020/01/09
Re: Review Request 71867: WIP: Support for docker containerizer.
Mesos Reviewbot
2020/01/09
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
2020/01/09
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
2020/01/09
Re: Review Request 71935: Added a new task status reason.
Mesos Reviewbot
2020/01/09
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
2020/01/09
Review Request 71977: Added systemd support to domain socket agent flag.
Benno Evers
2020/01/09
Review Request 71976: Added support for systemd socket activation API.
Benno Evers
2020/01/09
Re: Review Request 71833: Created unix domain socket on agent startup.
Benno Evers
2020/01/09
Re: Review Request 71816: Added domain socket-related flags to Mesos agent.
Benno Evers
2020/01/09
Re: Review Request 71815: Made the default executors connect via domain sockets if available.
Benno Evers
2020/01/09
Re: Review Request 71947: Handled embedded null bytes in abstract domain socket names.
Benno Evers
2020/01/09
Re: Review Request 71947: Handled embedded null bytes in abstract domain socket names.
Benno Evers
2020/01/09
Re: Review Request 71935: Added a new task status reason.
Greg Mann
2020/01/09
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Mesos Reviewbot
2020/01/09
Re: Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
2020/01/09
Re: Review Request 71978: Updated all GET_* v1 master calls to be served in parallel.
Mesos Reviewbot
2020/01/09
Re: Review Request 71944: Set container process's OOM score adjust.
Greg Mann
2020/01/09
Review Request 71978: Updated all GET_* v1 master calls to be served in parallel.
Benjamin Mahler
2020/01/08
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Mesos Reviewbot
2020/01/08
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
2020/01/08
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Qian Zhang
2020/01/08
Re: Review Request 71950: Updated containerizer's `update()` method to handle resource limits.
Qian Zhang
2020/01/08
Re: Review Request 71950: Updated containierzer's `update()` method to handle resource limits.
Qian Zhang
2020/01/08
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Mesos Reviewbot
2020/01/08
Re: Review Request 71971: Added special case to stout's handling of C++ attributes.
Mesos Reviewbot
2020/01/08
Re: Review Request 71971: Added special case to stout's handling of C++ attributes.
Benno Evers
2020/01/08
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
2020/01/08
Re: Review Request 71944: Set container process's OOM score adjust.
Qian Zhang
2020/01/08
Re: Review Request 71971: Added special case to stout's handling of C++ attributes.
Benjamin Bannier
2020/01/08
Re: Review Request 71971: Added special case to stout's handling of C++ attributes.
Benno Evers
2020/01/08
Re: Review Request 71971: Added special case to stout's handling of C++ attributes.
Benjamin Bannier
2020/01/08
Review Request 71971: Added special case to stout's handling of C++ attributes.
Benno Evers
2020/01/07
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Mesos Reviewbot
2020/01/07
Re: Review Request 71943: WIP: Set container's `memory.limit_in_bytes` to its memory limit.
Qian Zhang
2020/01/07
Re: Review Request 71886: WIP: Set container's `cpu.cfs_quota_us` to its CPU resource limit.
Qian Zhang
2020/01/07
Re: Review Request 71952: WIP: Set resource limits when updating executor container.
Qian Zhang
2020/01/07
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Qian Zhang
2020/01/07
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Qian Zhang
2020/01/07
Re: Review Request 71952: WIP: Set resource limits when updating executor container.
Qian Zhang
2020/01/07
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Qian Zhang
2020/01/07
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Greg Mann
2020/01/07
Re: Review Request 71951: Added resource limits into the `Task` protobuf message.
Greg Mann
2020/01/07
Re: Review Request 71950: Updated containierzer's `update()` method to handle resource limits.
Greg Mann
2020/01/07
Re: Review Request 71950: Updated containierzer's `update()` method to handle resource limits.
Greg Mann
2020/01/07
Re: Review Request 71944: Set container process's OOM score adjust.
Greg Mann
2020/01/07
Re: Review Request 71943: WIP: Set container's `memory.limit_in_bytes` to its memory limit.
Greg Mann
2020/01/07
Re: Review Request 71886: WIP: Set container's `cpu.cfs_quota_us` to its CPU resource limit.
Greg Mann
2020/01/07
Re: Review Request 71858: WIP: Set resource limits when launching executor container.
Greg Mann
2020/01/07
Re: Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Mesos Reviewbot
2020/01/07
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Mesos Reviewbot
2020/01/07
Re: Review Request 71865: Moved creating authorization Object out of `Master::authorizeSlave`.
Benjamin Mahler
2020/01/07
Re: Review Request 71864: Moved creating authorization Object out of `Master::authorize*reserve`.
Benjamin Mahler
2020/01/07
Re: Review Request 71864: Moved creating authorization Object out of `Master::authorize*reserve`.
Benjamin Mahler
2020/01/07
Re: Review Request 71863: Moved creating authorization Object out of `Master::authorize*Volume`.
Benjamin Mahler
2020/01/07
Re: Review Request 71862: Moved creating authorization Object out of `Master::authorize*Disk`.
Benjamin Mahler
2020/01/07
Re: Review Request 71861: Moved creating authz Object out of `Master::authorizeResizeVolume`.
Benjamin Mahler
2020/01/07
Review Request 71966: Cgroups isolator: added support for nested cgroups during recovery.
Andrei Budnik
2020/01/07
Review Request 71965: Cgroups isolator: added support for nested cgroups during launch.
Andrei Budnik
2020/01/07
Re: Review Request 71956: Added a test `ROOT_CGROUPS_CFS_CommandTaskLimits`.
Qian Zhang
2020/01/07
Re: Review Request 71953: Updated the test `ROOT_CGROUPS_CFS_EnableCfs` to check CFS quota.
Qian Zhang
2020/01/07
Re: Review Request 71961: Added deprecated absolute() function for backwards compatibility.
Benjamin Bannier
2020/01/07
Re: Review Request 71960: Added support for deprecated attribute to stout.
Benjamin Bannier
2020/01/07
Review Request 71961: Added deprecated absolute() function for backwards compatibility.
Benno Evers
Later messages