> On June 9, 2015, 2:32 a.m., Ben Mahler wrote: > > src/messages/flags.hpp, line 46 > > <https://reviews.apache.org/r/33296/diff/6/?file=980688#file980688line46> > > > > Looks like this comment is just repeating the line of code below it?
I copy/paste the code from `src/common/parse.hpp` but you're spot on! It really doesn't add anything. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33296/#review87099 ----------------------------------------------------------- On June 8, 2015, 2:11 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33296/ > ----------------------------------------------------------- > > (Updated June 8, 2015, 2:11 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till > Toenshoff. > > > Bugs: MESOS-2620 > https://issues.apache.org/jira/browse/MESOS-2620 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > docs/configuration.md 7d6e78649d0b13b536629bcdfdcb05ff76c7bc54 > src/Makefile.am ec7f41f2114d02d3d5a1434d9799f15fe9331917 > src/master/flags.hpp 84fa238e5d61731c157b05f7935392dd375d9938 > src/master/flags.cpp 49d953a4d2387fa2e28e594988df993762de86df > src/master/main.cpp 3d490c3a5cad59eb908054c3c3872d5540f45b8c > src/messages/flags.hpp PRE-CREATION > src/messages/flags.proto PRE-CREATION > src/slave/flags.hpp 32d36ac57ea7fe16c310fcf8a321312aa42b4b71 > src/slave/flags.cpp 1ae106ed59ba54d9cd1aab3f10ceeb8e2c95b19d > src/slave/main.cpp af090ae0dad782a31fc0309b57d8ef474ca74658 > > Diff: https://reviews.apache.org/r/33296/diff/ > > > Testing > ------- > > make check and manual tests. > > > Thanks, > > Alexander Rojas > >
