----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34703/#review88038 -----------------------------------------------------------
3rdparty/libprocess/src/tests/time_tests.cpp (line 42) <https://reviews.apache.org/r/34703/#comment140444> I suspect we need more test coverage than this. What are the boundary cases? Are they all checked? 3rdparty/libprocess/src/tests/time_tests.cpp (line 60) <https://reviews.apache.org/r/34703/#comment140445> I suspect we need more test coverage than this. What are the boundary cases? Are they all checked? 3rdparty/libprocess/src/time.cpp (line 16) <https://reviews.apache.org/r/34703/#comment140441> s/the 'time'/a 'time_t' value 3rdparty/libprocess/src/time.cpp (line 41) <https://reviews.apache.org/r/34703/#comment140443> Why can't we use strfmt_l with a locale argument that matches the output we want? 3rdparty/libprocess/src/time.cpp (line 42) <https://reviews.apache.org/r/34703/#comment140442> s/the RFC 1123/RFC1123 3rdparty/libprocess/src/time.cpp (line 85) <https://reviews.apache.org/r/34703/#comment140438> When I first read this, I thought that nsecs stands for "number_of_seconds". Only by reading the comment above did I find out that you mean nano seconds. Please use unambiguous, non-abbreviated identifiers - even if the 3rd party library functions in the vicinity have sloppy naming. By using "nanoSeconds" for the variable name, part of the comment will become redundant! 3rdparty/libprocess/src/time.cpp (line 86) <https://reviews.apache.org/r/34703/#comment140440> If you leave this line blank, it seems that the "Append" part of the comment above does not apply to what follows as of line 87. Alternatively add a blank line between 84 and 85. - Bernd Mathiske On June 15, 2015, 8:26 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34703/ > ----------------------------------------------------------- > > (Updated June 15, 2015, 8:26 a.m.) > > > Review request for mesos, Bernd Mathiske, Michael Park, Nikita Vetoshkin, and > Till Toenshoff. > > > Bugs: mesos-708 > https://issues.apache.org/jira/browse/mesos-708 > > > Repository: mesos > > > Description > ------- > > Adds some manipulator classes which allows formatting Time objects to > ostreams. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am c781f6ca38d87c47b4bdadf5ac2f59a02dd8c73c > 3rdparty/libprocess/include/process/time.hpp > c5ab2a3cfa83590eb6612152ae365dd67f51cea9 > 3rdparty/libprocess/src/tests/time_tests.cpp > be314182c65c05d439b81aa5248a71d93f6f0a0b > 3rdparty/libprocess/src/time.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/34703/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
