> On June 17, 2015, 4 p.m., Bernd Mathiske wrote:
> > 3rdparty/libprocess/src/process.cpp, line 2842
> > <https://reviews.apache.org/r/30032/diff/13/?file=986200#file986200line2842>
> >
> >     Here we can output mtime.error().

This one is a bad place since here `strftime` failed, which is unrelated to 
`mtime`. I did find a better place though.


> On June 17, 2015, 4 p.m., Bernd Mathiske wrote:
> > 3rdparty/libprocess/src/process.cpp, line 2861
> > <https://reviews.apache.org/r/30032/diff/13/?file=986200#file986200line2861>
> >
> >     No need to check mtime.isError(). It is actually a bit confusing all 
> > the explanations above.

I know the comment above is confusing, however it appears in all the 
`dispatch(proxy, &HttpProxy::enqueue, _, _)` in the file.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30032/#review88211
-----------------------------------------------------------


On June 17, 2015, 5:42 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30032/
> -----------------------------------------------------------
> 
> (Updated June 17, 2015, 5:42 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, Joerg Schad, 
> Michael Park, and Till Toenshoff.
> 
> 
> Bugs: mesos-708
>     https://issues.apache.org/jira/browse/mesos-708
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When serving a static file, libprocess returns the header `Last-Modified` 
> which is used by browsers to control Cache.
> When a http request arrives containing the header `If-Modified-Since`, a 
> response `304 Not Modified` is returned if the date in the request and the 
> modification time (as returned by doing `stat` in the file) coincide.
> Unit tests added.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 
> e47cc7afbc8110759edf25a2dc05d09eda25c417 
>   3rdparty/libprocess/src/process.cpp 
> a67a3afdb30d23eb1b265b04ae662f64e874b6c6 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> 660af45e7fd45bdf5d43ad9aa54477fd94f87058 
> 
> Diff: https://reviews.apache.org/r/30032/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to