----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35635/#review88475 -----------------------------------------------------------
src/slave/slave.cpp (lines 2904 - 2905) <https://reviews.apache.org/r/35635/#comment141032> Is this better? Seems to be making it more "jagged" IMO. src/slave/slave.cpp (lines 3120 - 3125) <https://reviews.apache.org/r/35635/#comment141031> Is this really better? Also we have a lot of code following this old style, I'm hesitant to introduce inconsistency. src/slave/slave.cpp (line 3371) <https://reviews.apache.org/r/35635/#comment141028> Hm.. we've been preferring to put continutations (.then / .onAny / etc) on a new line (consider that these are like statements / programmable semi-colons), so separate lines tends to be easier to read from what we've found. src/slave/slave.cpp (lines 3554 - 3560) <https://reviews.apache.org/r/35635/#comment141030> This is a detraction from the existing style IMO - Ben Mahler On June 19, 2015, 12:30 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35635/ > ----------------------------------------------------------- > > (Updated June 19, 2015, 12:30 a.m.) > > > Review request for mesos, Benjamin Hindman and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > This patch includes fixes for incorrect formatting as well as > acceptable-but-can-be-improved formatting. > > > Diffs > ----- > > src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b > > Diff: https://reviews.apache.org/r/35635/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > >
