----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35635/#review88510 -----------------------------------------------------------
Ship it! Is it manual clean-up or you have fed the file to clang-format? src/slave/slave.cpp (line 1263) <https://reviews.apache.org/r/35635/#comment141090> Will the compiler cache the temporary and re-use it? Does it make sense to extract `completedFrameworks.end()` from the loop? - Alexander Rukletsov On June 19, 2015, 2:23 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35635/ > ----------------------------------------------------------- > > (Updated June 19, 2015, 2:23 a.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > This patch includes fixes for incorrect formatting as well as > acceptable-but-can-be-improved formatting. > > > Diffs > ----- > > src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b > > Diff: https://reviews.apache.org/r/35635/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > >
