> On June 19, 2015, 12:40 a.m., Ben Mahler wrote: > > src/slave/slave.cpp, lines 3154-3159 > > <https://reviews.apache.org/r/35635/diff/1/?file=987708#file987708line3154> > > > > Is this really better? Also we have a lot of code following this old > > style, I'm hesitant to introduce inconsistency.
I've reverted this change and fixed other places where it was inconsistent with the old style. > On June 19, 2015, 12:40 a.m., Ben Mahler wrote: > > src/slave/slave.cpp, lines 3405-3406 > > <https://reviews.apache.org/r/35635/diff/1/?file=987708#file987708line3405> > > > > Hm.. we've been preferring to put continutations (.then / .onAny / etc) > > on a new line (consider that these are like statements / programmable > > semi-colons), so separate lines tends to be easier to read from what we've > > found. Reverted. > On June 19, 2015, 12:40 a.m., Ben Mahler wrote: > > src/slave/slave.cpp, lines 2929-2930 > > <https://reviews.apache.org/r/35635/diff/1/?file=987708#file987708line2929> > > > > Is this better? Seems to be making it more "jagged" IMO. I don't understand, could you explain how this is more "jagged"? > On June 19, 2015, 12:40 a.m., Ben Mahler wrote: > > src/slave/slave.cpp, lines 3589-3595 > > <https://reviews.apache.org/r/35635/diff/1/?file=987708#file987708line3589> > > > > This is a detraction from the existing style IMO Defining how many indents are considered "jagged" is something that came up in https://issues.apache.org/jira/browse/MESOS-2618. Anyway, I've reverted this change. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35635/#review88475 ----------------------------------------------------------- On June 19, 2015, 2:12 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35635/ > ----------------------------------------------------------- > > (Updated June 19, 2015, 2:12 a.m.) > > > Review request for mesos, Benjamin Hindman and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > This patch includes fixes for incorrect formatting as well as > acceptable-but-can-be-improved formatting. > > > Diffs > ----- > > src/slave/slave.cpp a5ad29f59fadba919ed82ba2892c2febe551660b > > Diff: https://reviews.apache.org/r/35635/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Michael Park > >
