----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35799/#review89042 -----------------------------------------------------------
src/docker/docker.cpp (lines 381 - 382) <https://reviews.apache.org/r/35799/#comment141647> Even though it reads fine, I think our style suggests a different wrapping: ``` volumeConfig = path::join(sandboxDirectory, volume.host_path()) + ":" + volumeConfig; ``` This should just fit the 80 chars limit if I am not mistaken. src/tests/docker_tests.cpp (line 48) <https://reviews.apache.org/r/35799/#comment141648> Let's move the brace down to the next line: ``` class DockerTest : public MesosTest { [...] ``` src/tests/docker_tests.cpp (line 53) <https://reviews.apache.org/r/35799/#comment141649> Insert blank line here. src/tests/docker_tests.cpp (line 60) <https://reviews.apache.org/r/35799/#comment141650> Out of curiosity, why 30 seconds? src/tests/docker_tests.cpp (line 334) <https://reviews.apache.org/r/35799/#comment141651> We are trying to get all tests documented a little, hence it would be great if you added a comment line or two on top, describing what the test validates. src/tests/docker_tests.cpp (line 340) <https://reviews.apache.org/r/35799/#comment141653> Insert blank line. src/tests/docker_tests.cpp (line 360) <https://reviews.apache.org/r/35799/#comment141654> I would either get rid of this `containerName` as you only use it once, or I would make it const if you plan to reuse it in later updates. - Till Toenshoff On June 23, 2015, 7:18 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35799/ > ----------------------------------------------------------- > > (Updated June 23, 2015, 7:18 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till > Toenshoff. > > > Bugs: MESOS-2374 > https://issues.apache.org/jira/browse/MESOS-2374 > > > Repository: mesos > > > Description > ------- > > Support mounting relative paths with docker. > > > Diffs > ----- > > src/docker/docker.cpp 4e1300300392b404b6dcf62631492112fa4939ba > src/tests/docker_tests.cpp acf1e3c8f455e8b40e4b3cb8748fcfeacbab142c > > Diff: https://reviews.apache.org/r/35799/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
