----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35799/#review89147 -----------------------------------------------------------
src/tests/docker_tests.cpp (line 333) <https://reviews.apache.org/r/35799/#comment141746> So this tests is for mounting a volume with a relative path. How about testing the opposite, using an absolute path? src/tests/docker_tests.cpp (line 367) <https://reviews.apache.org/r/35799/#comment141747> Use Flags::docker_sandbox_directory (or a constant that the flag also uses for its default value) instead. Not only will this fix the naked constant problem, it will also explain what this parameter does and make readers understand the test code much more quickly. I know this is copy-paste-induced, but the original is really, really bad. Please either fix now, or leave a TODO and a tech debt ticket. - Bernd Mathiske On June 23, 2015, 12:18 p.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35799/ > ----------------------------------------------------------- > > (Updated June 23, 2015, 12:18 p.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till > Toenshoff. > > > Bugs: MESOS-2374 > https://issues.apache.org/jira/browse/MESOS-2374 > > > Repository: mesos > > > Description > ------- > > Support mounting relative paths with docker. > > > Diffs > ----- > > src/docker/docker.cpp 4e1300300392b404b6dcf62631492112fa4939ba > src/tests/docker_tests.cpp acf1e3c8f455e8b40e4b3cb8748fcfeacbab142c > > Diff: https://reviews.apache.org/r/35799/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Timothy Chen > >
