> On June 23, 2015, 8:10 p.m., Till Toenshoff wrote:
> > src/tests/docker_tests.cpp, line 60
> > <https://reviews.apache.org/r/35799/diff/1/?file=990751#file990751line60>
> >
> >     Out of curiosity, why 30 seconds?

Good question, it's the same timeout I've used in docker containerizer tests 
for just a arbitrary time. 30 seconds to me sounds like a long enough time to 
wait for a container to shutdown even on a very slow system.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35799/#review89042
-----------------------------------------------------------


On June 23, 2015, 7:18 p.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35799/
> -----------------------------------------------------------
> 
> (Updated June 23, 2015, 7:18 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-2374
>     https://issues.apache.org/jira/browse/MESOS-2374
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Support mounting relative paths with docker.
> 
> 
> Diffs
> -----
> 
>   src/docker/docker.cpp 4e1300300392b404b6dcf62631492112fa4939ba 
>   src/tests/docker_tests.cpp acf1e3c8f455e8b40e4b3cb8748fcfeacbab142c 
> 
> Diff: https://reviews.apache.org/r/35799/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Reply via email to