> On June 9, 2015, 12:32 a.m., Ben Mahler wrote: > > 3rdparty/libprocess/src/tests/process_tests.cpp, line 1930 > > <https://reviews.apache.org/r/33295/diff/10/?file=980632#file980632line1930> > > > > Any reason you could't use initializer list construction for this?
Lets add a `TODO(arojas): Use initializer-list for construction once available. See MESOS-2924.` - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/#review87100 ----------------------------------------------------------- On June 8, 2015, 10:09 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33295/ > ----------------------------------------------------------- > > (Updated June 8, 2015, 10:09 a.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till > Toenshoff. > > > Bugs: MESOS-2620 > https://issues.apache.org/jira/browse/MESOS-2620 > > > Repository: mesos > > > Description > ------- > > Introduces the interface `FirewallRule` which will be matched against > incoming connections in order to allow them to be served or being blocked. > For details, check the [design > doc](https://docs.google.com/document/d/1JSJTJMJ6ZXLkCSmvOIabTLrjtqqr0E-u99Rx2BHR1hs/edit). > > > Diffs > ----- > > 3rdparty/libprocess/include/Makefile.am > f45e7c5c0fad063cc0b34ec7977cef685c2909d3 > 3rdparty/libprocess/include/process/firewall.hpp PRE-CREATION > 3rdparty/libprocess/include/process/process.hpp > 79d1719932a3fdc90b6247d3a77adee123e72435 > 3rdparty/libprocess/src/process.cpp > d1b4d469a11abc618c1406bce602300dd9793b58 > 3rdparty/libprocess/src/tests/process_tests.cpp > 7b9ba9e70e1fe7a22b26444b3bd928208fecd491 > > Diff: https://reviews.apache.org/r/33295/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
