> On June 1, 2015, 1:06 a.m., Adam B wrote:
> > 3rdparty/libprocess/include/process/firewall.hpp, lines 54-55
> > <https://reviews.apache.org/r/33295/diff/6/?file=964946#file964946line54>
> >
> >     Please capitalize "The" beginning of each @param description.
> 
> Alexander Rojas wrote:
>     I do completely agree with you, and actually it was like that in an 
> earlier version of the 
> [patch](https://reviews.apache.org/r/33295/diff/1/?file=933068#file933068line270)
>  however a previous review requested to change it because lowercase is the 
> way we do it in libprocess (run `grep --include="*.[ch]pp" --include="*.[ch]" 
> --exclude="*_tests.cpp" --exclude-dir="build" -RFIn '@param' .`)

I don't think that 10 improperly capitalized/punctuated comments in process.hpp 
dating back to 2011-12 necessarily indicate the intended trend across all of 
libprocess. If that's the case, you should remove the ending punctuation too. ;)
Ask @benh (sole author of those comments) if we can set a new standard for 
doxygen comments in libprocess.


- Adam


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33295/#review85950
-----------------------------------------------------------


On June 1, 2015, 8:52 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33295/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 8:52 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-2620
>     https://issues.apache.org/jira/browse/MESOS-2620
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduces the interface `FirewallRule` which will be matched against 
> incoming connections in order to allow them to be served or being blocked. 
> For details, check the [design 
> doc](https://docs.google.com/document/d/1JSJTJMJ6ZXLkCSmvOIabTLrjtqqr0E-u99Rx2BHR1hs/edit).
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/Makefile.am 
> 8aab0593f296c7aae71289f9bd6cf3eb3578a721 
>   3rdparty/libprocess/include/process/firewall.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/process.hpp 
> 79d1719932a3fdc90b6247d3a77adee123e72435 
>   3rdparty/libprocess/src/process.cpp 
> e3de3cd6b536aaaf59784360aed546512dd04dc9 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> 67e582cc250a9767a389e2bd0cc68985477f3ffb 
> 
> Diff: https://reviews.apache.org/r/33295/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to