-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33295/#review86169
-----------------------------------------------------------

Ship it!


Add an @return and fix the nits, and I'm ready to commit this.


3rdparty/libprocess/include/process/firewall.hpp
<https://reviews.apache.org/r/33295/#comment138095>

    Can you remove the now obsolete "If it returns 'false'" statement and 
replace it with an appropriate @return statement below the @params?



3rdparty/libprocess/include/process/firewall.hpp
<https://reviews.apache.org/r/33295/#comment138097>

    "Matches must be exact; neither substrings nor wildcards are considered."



3rdparty/libprocess/include/process/firewall.hpp
<https://reviews.apache.org/r/33295/#comment138098>

    Since you're wrapping at all, go ahead and put each parameter on a separate 
line.



3rdparty/libprocess/include/process/firewall.hpp
<https://reviews.apache.org/r/33295/#comment138099>

    Error("Endpoint '" + ...
    s/dissabled/disabled/



3rdparty/libprocess/include/process/process.hpp
<https://reviews.apache.org/r/33295/#comment138100>

    s/ails,/fails,/



3rdparty/libprocess/include/process/process.hpp
<https://reviews.apache.org/r/33295/#comment138101>

    s/will will be/which will be/



3rdparty/libprocess/src/tests/process_tests.cpp
<https://reviews.apache.org/r/33295/#comment138103>

    What happened to your .WillOnce tabbing? Please make it a consistent 
2-space indent.


- Adam B


On June 1, 2015, 8:52 a.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33295/
> -----------------------------------------------------------
> 
> (Updated June 1, 2015, 8:52 a.m.)
> 
> 
> Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-2620
>     https://issues.apache.org/jira/browse/MESOS-2620
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduces the interface `FirewallRule` which will be matched against 
> incoming connections in order to allow them to be served or being blocked. 
> For details, check the [design 
> doc](https://docs.google.com/document/d/1JSJTJMJ6ZXLkCSmvOIabTLrjtqqr0E-u99Rx2BHR1hs/edit).
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/Makefile.am 
> 8aab0593f296c7aae71289f9bd6cf3eb3578a721 
>   3rdparty/libprocess/include/process/firewall.hpp PRE-CREATION 
>   3rdparty/libprocess/include/process/process.hpp 
> 79d1719932a3fdc90b6247d3a77adee123e72435 
>   3rdparty/libprocess/src/process.cpp 
> e3de3cd6b536aaaf59784360aed546512dd04dc9 
>   3rdparty/libprocess/src/tests/process_tests.cpp 
> 67e582cc250a9767a389e2bd0cc68985477f3ffb 
> 
> Diff: https://reviews.apache.org/r/33295/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>

Reply via email to