-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/
-----------------------------------------------------------
(Updated June 24, 2015, 3:39 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, Joris
Van Remoortere, and Vinod Kone.
Bugs: MESOS-2600
https://issues.apache.org/jira/browse/MESOS-2600
Repository: mesos
Description (updated)
-------
Work currently in progress, incorporating feedback. Please hold off on
reviewing this patch for now.
(1) Q: I've added `updateAvailable` to the allocator API. Is this necessary or
is there maybe a better way?
A: I think we shold be able to generalize `updateSlave` to support not only
`oversubscription`, but `reserve`, `unreserve`, `create` and `destroy`.
(2) Q: To determine the amount of available resources, I used: `available =
total - (offered + used)`.
Is this still correct with oversubscription in the picture?
A: I think this decision needs to be made in the allocator.
(3) Q: I'm creating an `Offer.Operation` to perform the necessary updates in
the allocator and such.
Feels weird to use an "offer" operation when there's not an actual
offer. Is this fine for now?
A: I think we'll want to introduce something like `Resource.Operation`.
Diffs
-----
include/mesos/master/allocator.hpp 92de1af414321281b00eaa6f129e5e3e2c849448
src/Makefile.am dfebd2b14c9cb45c437509809fdf5ac3b0c8838c
src/master/allocator/mesos/allocator.hpp
6cfa04650d91a80211cfbc0809236f9438926c78
src/master/allocator/mesos/hierarchical.hpp
7097482fc0adad1c177c15c35edd51c10754f89c
src/master/http.cpp b893013ddd052cb58c520ac0328f4a5f0fed862e
src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064
src/master/master.cpp 0135c155181546d3cb43e9e05bb874af846d928d
src/master/validation.hpp 469d6f56c3de28a34177124aae81ce24cb4ad160
src/master/validation.cpp 9d128aa1b349b018b8e4a1916434d848761ca051
src/tests/mesos.hpp 9157ac079808d2686592e54ea26a26e6a0825ed3
src/tests/reserve_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/35702/diff/
Testing
-------
Added `src/tests/reserve_tests.cpp`.
Thanks,
Michael Park
