-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35721/#review89247
-----------------------------------------------------------


This is good, see my only comment, not even sure that's an issue here.
Can we please however test this (also with NFS mounts - they do behave 
sometimes weirdly when it comes to chown on mounts)


src/slave/slave.cpp (line 2154)
<https://reviews.apache.org/r/35721/#comment141836>

    you don't actually need the `true` (that is the default value).
    
    But I do wonder whether the recursive behavior is the desired one here?
    it risks making data/resources (in subdirs, created by different users) 
unavailable for processes/tasks that are run.
    
    We should probably also LOG(INFO) here as it may help when debugging 
"permission denied" issues.


- Marco Massenzio


On June 22, 2015, 1:56 a.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35721/
> -----------------------------------------------------------
> 
> (Updated June 22, 2015, 1:56 a.m.)
> 
> 
> Review request for mesos, Adam B and Jie Yu.
> 
> 
> Bugs: MESOS-2603
>     https://issues.apache.org/jira/browse/MESOS-2603
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Set the owner of persistent volumes to frameworkInfo.user .
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 0135c155181546d3cb43e9e05bb874af846d928d 
>   src/messages/messages.proto 1c8d79e3fca365520cdd67051f8730593955cab6 
>   src/slave/slave.hpp f1cf3b85ccb3eaf614fe844c830f7cc44f7916fe 
>   src/slave/slave.cpp 40c0c33add392591af4767f76ce566196f24e6ee 
> 
> Diff: https://reviews.apache.org/r/35721/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to