----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/#review89715 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/src/process.cpp (line 2017) <https://reviews.apache.org/r/35919/#comment142395> Might return all kinds of HTTP return codes, no? 3rdparty/libprocess/src/process.cpp (line 2019) <https://reviews.apache.org/r/35919/#comment142396> Use that HTTP status code here instead of `body` to make sure we always (also in the future) get a nice log output (mind there may even be HTML within the body). 3rdparty/libprocess/src/process.cpp (line 2029) <https://reviews.apache.org/r/35919/#comment142400> How about adding a `CHECK(rejection.get() != NULL)` here somewhere? - Till Toenshoff On June 26, 2015, 10:18 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35919/ > ----------------------------------------------------------- > > (Updated June 26, 2015, 10:18 a.m.) > > > Review request for mesos, Adam B and Till Toenshoff. > > > Bugs: MESOS-2877 > https://issues.apache.org/jira/browse/MESOS-2877 > > > Repository: mesos > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/firewall.hpp > f71d6541e48e2481c69f401b388977b153503962 > 3rdparty/libprocess/src/process.cpp > 52649fb90cdbefb495b68d0beb8c7f7e5ef6888e > > Diff: https://reviews.apache.org/r/35919/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
