> On June 30, 2015, 6:08 a.m., Adam B wrote: > > Minor points, but otherwise shippable. > > I guess I'm still a little confused by the motivation. When would the > > firewall filter rule have more information about how to respond than the > > caller would? Can you give an example?
The idea is to implement SPNEGO in the least intrusive way. That can be achieve with an `FirewallRule`. The problem happens if the request doesn't include the header `Authenticate: Negotiate`, in such case, we should return an `HTTP 401 Unauthorize` response with a header `WWW-Authenticate: Negotiate U29tZSB0ZXh0Cg==`. But this cannot be done if we cannot generate the response object directly from the `FirewallRule`. > On June 30, 2015, 6:08 a.m., Adam B wrote: > > 3rdparty/libprocess/src/process.cpp, lines 2019-2020 > > <https://reviews.apache.org/r/35919/diff/3/?file=994356#file994356line2019> > > > > You're not logging the Response body anymore? Previous reviewer asked to remove it. What should be done in this case? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/#review89854 ----------------------------------------------------------- On June 29, 2015, 12:21 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35919/ > ----------------------------------------------------------- > > (Updated June 29, 2015, 12:21 p.m.) > > > Review request for mesos, Adam B and Till Toenshoff. > > > Bugs: MESOS-2877 > https://issues.apache.org/jira/browse/MESOS-2877 > > > Repository: mesos > > > Description > ------- > > see summary. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/firewall.hpp > f71d6541e48e2481c69f401b388977b153503962 > 3rdparty/libprocess/src/process.cpp > 52649fb90cdbefb495b68d0beb8c7f7e5ef6888e > > Diff: https://reviews.apache.org/r/35919/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
