> On June 27, 2015, 6:59 p.m., Adam B wrote:
> > src/java/mesos.pom.in, line 134
> > <https://reviews.apache.org/r/35961/diff/1/?file=993817#file993817line134>
> >
> >     Is `${project.basedir}/generated` any better/different than 
> > `@abs_top_builddir@/src/java/generated`
> 
> Connor Doyle wrote:
>     Probably not, will update to use `@abs_top_builddir@` instead.

Updated and verified.


- Connor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35961/#review89629
-----------------------------------------------------------


On June 29, 2015, 3:53 p.m., Connor Doyle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35961/
> -----------------------------------------------------------
> 
> (Updated June 29, 2015, 3:53 p.m.)
> 
> 
> Review request for mesos, Adam B and Ben Whitehead.
> 
> 
> Bugs: MESOS-1552
>     https://issues.apache.org/jira/browse/MESOS-1552
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> Updates the Java POM to include the generated Java protobuf classes.
> 
> 
> Diffs
> -----
> 
>   src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in c54d903 
>   src/java/mesos.pom.in 138da55 
>   src/java/src/org/apache/mesos/MesosExecutorDriver.java 1b5ed60 
> 
> Diff: https://reviews.apache.org/r/35961/diff/
> 
> 
> Testing
> -------
> 
> - configure
> - make
> - Manual verification of generated Javadoc HTML
> 
> 
> Thanks,
> 
> Connor Doyle
> 
>

Reply via email to