> On June 27, 2015, 6:59 p.m., Adam B wrote:
> > Thanks for doing this Connor! Just a couple of questions about javadoc 
> > parsing of html (I'm no expert, just googled a few things).
> > Do we need to do a pass over our protos now to convert any `//` or `/*` 
> > block comments to `/**` comments? Worth a follow-up JIRA/patch? Most of 
> > mesos.proto looks fine, except TrafficControlStatistics and 
> > ResourceStatistics. And I'm not sure how public these need to be, but 
> > messages.proto is all `//` style, or completely missing comments.

I think it makes sense to modify the comment style in a follow-up patch.  As 
you mentioned the classes generated from mesos.proto already look pretty good.


- Connor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35961/#review89629
-----------------------------------------------------------


On June 29, 2015, 3:53 p.m., Connor Doyle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35961/
> -----------------------------------------------------------
> 
> (Updated June 29, 2015, 3:53 p.m.)
> 
> 
> Review request for mesos, Adam B and Ben Whitehead.
> 
> 
> Bugs: MESOS-1552
>     https://issues.apache.org/jira/browse/MESOS-1552
> 
> 
> Repository: mesos-incubating
> 
> 
> Description
> -------
> 
> Updates the Java POM to include the generated Java protobuf classes.
> 
> 
> Diffs
> -----
> 
>   src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in c54d903 
>   src/java/mesos.pom.in 138da55 
>   src/java/src/org/apache/mesos/MesosExecutorDriver.java 1b5ed60 
> 
> Diff: https://reviews.apache.org/r/35961/diff/
> 
> 
> Testing
> -------
> 
> - configure
> - make
> - Manual verification of generated Javadoc HTML
> 
> 
> Thanks,
> 
> Connor Doyle
> 
>

Reply via email to