> On June 27, 2015, 11:59 a.m., Adam B wrote:
> > src/java/mesos.pom.in, line 134
> > <https://reviews.apache.org/r/35961/diff/1/?file=993817#file993817line134>
> >
> > Is `${project.basedir}/generated` any better/different than
> > `@abs_top_builddir@/src/java/generated`
>
> Connor Doyle wrote:
> Probably not, will update to use `@abs_top_builddir@` instead.
>
> Connor Doyle wrote:
> Updated and verified.
`${project.basedir}/generated` is a maven interprited variable rather than a
configure interprited variable, so it's evaluated based on the context in which
maven is started. It would be convenient to try and keep the maven pom as
close to vanilla maven as possible to reduce the complexities when dealing with
that file. Perhaps this is something that can be cleaned up at a latter point.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35961/#review89629
-----------------------------------------------------------
On June 29, 2015, 8:53 a.m., Connor Doyle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35961/
> -----------------------------------------------------------
>
> (Updated June 29, 2015, 8:53 a.m.)
>
>
> Review request for mesos, Adam B and Ben Whitehead.
>
>
> Bugs: MESOS-1552
> https://issues.apache.org/jira/browse/MESOS-1552
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> Updates the Java POM to include the generated Java protobuf classes.
>
>
> Diffs
> -----
>
> src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in c54d903
> src/java/mesos.pom.in 138da55
> src/java/src/org/apache/mesos/MesosExecutorDriver.java 1b5ed60
>
> Diff: https://reviews.apache.org/r/35961/diff/
>
>
> Testing
> -------
>
> - configure
> - make
> - Manual verification of generated Javadoc HTML
>
>
> Thanks,
>
> Connor Doyle
>
>
