> On June 29, 2015, 11:17 a.m., Adam B wrote: > > src/common/validation.hpp, lines 27-34 > > <https://reviews.apache.org/r/35711/diff/7/?file=993941#file993941line27> > > > > I'm not convinced this is the right namespace/scope for a freestanding > > validate() function. Maybe, like we have a Resource protobuf message and a > > Resources class with parse() and validate(), we should also have a > > Roles::validate(). > > Jie Yu wrote: > +1 > > Initially, the patch only contains validation at the master's side, and > that's the reason I sugguested to put that into master/validation.hpp|cpp. I > agree with Adam that putting that in Roles. Sorry about that!
Thank you for your review. Let me update it. @jieyu @adam-mesos - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/#review89630 ----------------------------------------------------------- On June 27, 2015, 11:35 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35711/ > ----------------------------------------------------------- > > (Updated June 27, 2015, 11:35 a.m.) > > > Review request for mesos, Adam B and Jie Yu. > > > Bugs: MESOS-2210 > https://issues.apache.org/jira/browse/MESOS-2210 > > > Repository: mesos > > > Description > ------- > > Disallow special characters in role name. > > > Diffs > ----- > > src/Makefile.am a064d17a6b62e6e3c8e190135bcc8cbbb0051ed5 > src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521 > src/common/validation.hpp PRE-CREATION > src/common/validation.cpp PRE-CREATION > src/master/flags.cpp 4377715029878cfee36f067e9c53c42b522b79d8 > src/slave/flags.cpp 6ba5a1bdc9f91aa1977f13b3aeec0fe0604687a0 > src/tests/common/validation_tests.cpp PRE-CREATION > src/tests/resources_tests.cpp 30c10f3246b807800985f20f8835090657a2d56e > > Diff: https://reviews.apache.org/r/35711/diff/ > > > Testing > ------- > > make -j8 check > > > Thanks, > > haosdent huang > >
