-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/
-----------------------------------------------------------
(Updated June 30, 2015, 8:29 a.m.)
Review request for mesos, Adam B and Jie Yu.
Bugs: MESOS-2210
https://issues.apache.org/jira/browse/MESOS-2210
Repository: mesos
Description
-------
Disallow special characters in role name.
Diffs (updated)
-----
CHANGELOG 252f068383308c5f07a0fced8cda954f288c9591
docs/mesos-markdown-style-guide.md fe9ffefbbb2c0ce9ade39cec1de073163a9a03b2
docs/upgrades.md cef055b95ac1167fcc5f0f7251fafda113840eda
include/mesos/mesos.proto 5ab3c4a305562af16af804e7ab77e576b96e468d
include/mesos/roles.hpp PRE-CREATION
src/Makefile.am a064d17a6b62e6e3c8e190135bcc8cbbb0051ed5
src/common/protobuf_utils.hpp afe5a85d3f58eaabb16807253c5fcc07cabcf8e8
src/common/protobuf_utils.cpp f0642ba12b914889a876d1d1c49a2c242006433c
src/common/resources.cpp eb5476a0365fe65f474afd0ab7a52ad7f1e04521
src/common/roles.cpp PRE-CREATION
src/common/type_utils.cpp f7b21c6abc392fec0514224ff02a00e772389f5d
src/exec/exec.cpp a1ae074b962d8e93ab7776bd624389857da486f3
src/java/generated/org/apache/mesos/MesosNativeLibrary.java.in
34b8acb6512819ed89a737cdcc6c516eafb44cbe
src/java/mesos.pom.in 7615d61eb6fedfa0ead785cd360946c56ccf80af
src/java/src/org/apache/mesos/MesosExecutorDriver.java
6741b3239daa435045ab01f830cf495dd2e65a3f
src/master/flags.cpp 60ac64d98d53f74f904846b27a3833a7c44a9756
src/master/master.hpp af83d3e82d2c161b3cc4583e78a8cbbd2f9a4064
src/master/master.cpp 34ce744f84465ecc9aeecd5fdc3d06047a4b7d92
src/messages/messages.proto 165a16d91616b75c839c7fbf188dc49f029a8c45
src/sched/sched.cpp 7563abb85819b0b2bc9afdfd810b33c923c2522e
src/scheduler/scheduler.cpp f360e4d062488986b14e3d48d140996e8ed9e7d6
src/slave/flags.cpp 8632677ebbdbfef8ffa45204b6f63a700baff7f3
src/slave/slave.cpp 008170f4ce7b97eda43b50b48083b32ae65925c0
src/slave/status_update_manager.cpp 1978ac8ab370f3e20f5c3c803beda468edf31e2c
src/tests/fault_tolerance_tests.cpp 1070ccf17f98f6b3800684a5edd6517d90631c3e
src/tests/hook_tests.cpp 09205fb89925c22b1157294a756db87d911a63db
src/tests/isolator_tests.cpp 8eb732fe90dbab11967e663a5c06890f79463488
src/tests/partition_tests.cpp a1fb6f730e4b28758a8f03ad31f463b115194a6e
src/tests/resources_tests.cpp 30c10f3246b807800985f20f8835090657a2d56e
src/tests/roles_tests.cpp PRE-CREATION
src/tests/slave_tests.cpp 4ddc608ab9636fcc0166e8c80a252dcf67b45ad3
src/webui/master/static/browse.html 0904c879de9cd602f23d749ad40ff56d5a2b0770
support/post-reviews.py b04e26b85e6b056098c15078f9b31dc352682351
Diff: https://reviews.apache.org/r/35711/diff/
Testing
-------
make -j8 check
Thanks,
haosdent huang
