----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/#review90140 -----------------------------------------------------------
src/linux/cgroups.hpp (lines 438 - 440) <https://reviews.apache.org/r/36106/#comment143125> can you please use the Javadoc notation instead (as documented in the style guide)? also, please make sure to document @param, @return src/linux/cgroups.hpp (line 452) <https://reviews.apache.org/r/36106/#comment143127> does the string need the trailing space before the newline? src/linux/cgroups.hpp (line 479) <https://reviews.apache.org/r/36106/#comment143128> unnecessary blank line src/linux/cgroups.cpp (line 2002) <https://reviews.apache.org/r/36106/#comment143130> and, in any event, the variables should have a meaningful name - should these be `userTime` or something? (also, if they are time durations, please pre-pend the unit: `userTimeSec`) - Marco Massenzio On July 1, 2015, 9:38 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36106/ > ----------------------------------------------------------- > > (Updated July 1, 2015, 9:38 p.m.) > > > Review request for mesos, Ian Downes, Joris Van Remoortere, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > cgroups implementation does not have a cpuacct subsystem implementation as of > today. Adding the implementation for stat function. > > Changes: > - added Stats class to encapsulate cpuacct.stat data > - added implementation for cpuacct::stats > - added unit tests > > Jira: MESOS-2961 > > > Diffs > ----- > > src/linux/cgroups.hpp 73b98317880eea3d6a2ba37ac56d1f7e3600ba94 > src/linux/cgroups.cpp 4c006d0c7382b940a83359d636c0d48952cdbb00 > src/tests/cgroups_tests.cpp 475f48a474eea708f98d8c0300862351a2d4379a > > Diff: https://reviews.apache.org/r/36106/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jojy Varghese > >
